Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 fix verify-release.sh to understand go directive better #1895

Merged
merged 1 commit into from
Aug 15, 2024
Merged

🌱 fix verify-release.sh to understand go directive better #1895

merged 1 commit into from
Aug 15, 2024

Conversation

metal3-io-bot
Copy link
Contributor

This is an automated cherry-pick of #1890

/assign tuminoid

@tuminoid
fix verify-release.sh to understand go directive better
8dd3770 
Currently it fails to do the vulnerability scan if the go directive
has golang patch version in it, like "1.22.3", as it replaces "1.22"
with "1.22.5" it finds from Dockerfile, resulting to "1.22.5.3"
which blows up.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@metal3-io-bot metal3-io-bot mentioned this pull request Aug 14, 2024
Merged
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 14, 2024
@tuminoid
Copy link
Member

/retitle 🌱 fix verify-release.sh to understand go directive better
/override metal3-ubuntu-e2e-integration-test-release-1-6

@metal3-io-bot metal3-io-bot changed the title [release-1.6] 🌱 fix verify-release.sh to understand go directive better 🌱 fix verify-release.sh to understand go directive better Aug 14, 2024
@metal3-io-bot
Copy link
Contributor Author

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-release-1-6

In response to this:

/retitle 🌱 fix verify-release.sh to understand go directive better
/override metal3-ubuntu-e2e-integration-test-release-1-6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tuminoid
tuminoid reviewed Aug 14, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2024
Sunnatillo
Sunnatillo reviewed Aug 15, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2024
@metal3-io-bot metal3-io-bot merged commit c9433e2 into metal3-io:release-1.6 Aug 15, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunnatillo Sunnatillo Sunnatillo left review comments

@tuminoid tuminoid tuminoid left review comments

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@dtantsur dtantsur Awaiting requested review from dtantsur

Assignees

@tuminoid tuminoid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metal3-io-bot @tuminoid @Sunnatillo