Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Update job triggers documents #1956

Merged
merged 1 commit into from
Sep 4, 2024
Merged

📖 Update job triggers documents #1956

merged 1 commit into from
Sep 4, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Sep 4, 2024

Update job triggers after release-1.8

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 4, 2024
@tuminoid
Copy link
Member

tuminoid commented Sep 4, 2024

/retitle 📖 Update job triggers documents

@metal3-io-bot metal3-io-bot changed the title 🌱 Update job triggers 📖 Update job triggers documents Sep 4, 2024
@mquhuy
Update job triggers
1efe764 
Signed-off-by: Huy Mai <[email protected]>
@mquhuy mquhuy force-pushed the mquhuy/update-job-triggers-main branch from 3497270 to 1efe764 Compare September 4, 2024 06:32
@mquhuy mquhuy mentioned this pull request Sep 4, 2024
Open
49 tasks
tuminoid
tuminoid reviewed Sep 4, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2024
Sunnatillo
Sunnatillo approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2024
Sunnatillo
Sunnatillo approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sunnatillo, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Sunnatillo,tuminoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Sunnatillo
Copy link
Member

Sunnatillo commented Sep 4, 2024 •
edited
Loading

/override metal3-centos-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

@Sunnatillo: Overrode contexts on behalf of Sunnatillo: metal3-centos-e2e-integration-test-main

In response to this:

/override metal3-centos-e2e-integration-test-main
//override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Sunnatillo
Copy link
Member

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

@Sunnatillo: Overrode contexts on behalf of Sunnatillo: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot merged commit 2698d09 into metal3-io:main Sep 4, 2024
13 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/update-job-triggers-main branch September 4, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@Sunnatillo Sunnatillo Sunnatillo approved these changes

@Rozzii Rozzii Awaiting requested review from Rozzii

@zhouhao3 zhouhao3 Awaiting requested review from zhouhao3

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mquhuy @tuminoid @metal3-io-bot @Sunnatillo