Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump golang to 1.22.7 #1967

Merged
merged 1 commit into from
Sep 9, 2024
Merged

🌱 Bump golang to 1.22.7 #1967

merged 1 commit into from
Sep 9, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Sep 6, 2024

Bump golang to 1.22.7

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 6, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Sep 6, 2024

/cc @kashifest @tuminoid @Sunnatillo @adilGhaffarDev

@mquhuy
Copy link
Member Author

mquhuy commented Sep 6, 2024

/test metal3-centos-e2e-integration-test-release-1-8

tuminoid
tuminoid reviewed Sep 6, 2024
View reviewed changes
api/go.mod Outdated
@@ -1,6 +1,6 @@
module github.com/metal3-io/cluster-api-provider-metal3/api

go 1.22.3
go 1.22.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't bump go mods

tuminoid
tuminoid requested changes Sep 6, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2024
@tuminoid
Copy link
Member

tuminoid commented Sep 6, 2024

/approve cancel
Don't bump go mods.

@metal3-io-bot metal3-io-bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2024
@mquhuy
Bump Golang to 1.22.7
bc6fb31 
Signed-off-by: Huy Mai <[email protected]>
@metal3-io-bot metal3-io-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 6, 2024
tuminoid
tuminoid approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2024
kashifest
kashifest reviewed Sep 8, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2024
@tuminoid
Copy link
Member

tuminoid commented Sep 9, 2024

/test metal3-centos-e2e-integration-test-release-1-8

@metal3-io-bot metal3-io-bot merged commit adee216 into metal3-io:release-1.8 Sep 9, 2024
17 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/bump-golang-1.22.7 branch September 9, 2024 07:00
@tuminoid
Copy link
Member

tuminoid commented Sep 9, 2024

/cherry-pick main

@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #1968

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot mentioned this pull request Sep 9, 2024
Merged
@tuminoid
Copy link
Member

tuminoid commented Sep 9, 2024

/cherry-pick release-1.7

@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #1969

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot mentioned this pull request Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@tuminoid tuminoid tuminoid approved these changes

@dtantsur dtantsur Awaiting requested review from dtantsur

@mboukhalfa mboukhalfa Awaiting requested review from mboukhalfa

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@Sunnatillo Sunnatillo Awaiting requested review from Sunnatillo

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mquhuy @tuminoid @metal3-io-bot @kashifest