Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Enable redfish-https boot interface #561

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

derekhiggins
Copy link
Member

@derekhiggins derekhiggins commented Sep 12, 2024

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 12, 2024
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add appropriate emoji (probably 🌱 ) and sign-off the commit to pass DCO.

@tuminoid
Copy link
Member

/cc @Rozzii

@derekhiggins derekhiggins changed the title Enable redfish-https boot interface ✨ Enable redfish-https boot interface Sep 13, 2024
Enable interface to allow UefiHttp boot.

Signed-off-by: Derek Higgins <[email protected]>
@derekhiggins
Copy link
Member Author

Add appropriate emoji (probably 🌱 ) and sign-off the commit to pass DCO.

thanks, I added ✨ as we're enabling a new feature

@dtantsur
Copy link
Member

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main
/approve

A link to the design proposal in the PR description would be nice.

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2024
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2024
@metal3-io-bot metal3-io-bot merged commit 58be3ea into metal3-io:main Sep 16, 2024
8 checks passed
dtantsur pushed a commit to dtantsur/ironic-image that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants