Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Take Deploy-cli to replace deploy.sh #1447

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱 Take Deploy-cli to replace deploy.sh #1447

wants to merge 1 commit into from

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Aug 13, 2024 •
edited
Loading

This PR is currently used to test metal3-io/baremetal-operator#1669 Eventually we could consider merging it (to use deploy-cli in CI), but for now let's hold

This PR takes Deploy-cli into use to replace deploy.sh in dev-env deployment and tests.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2024
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lentzi90 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 13, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Aug 13, 2024

/test metal3-dev-env-integration-test-ubuntu-main
/test metal3-dev-env-integration-test-centos-main

@mquhuy mquhuy marked this pull request as draft August 13, 2024 06:38
@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2024
@mquhuy mquhuy marked this pull request as ready for review August 13, 2024 06:38
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Aug 13, 2024

/test metal3-dev-env-integration-test-ubuntu-main
/test metal3-dev-env-integration-test-centos-main

@mquhuy mquhuy mentioned this pull request Aug 13, 2024
Merged
@mquhuy
Copy link
Member Author

mquhuy commented Aug 14, 2024

/test metal3-dev-env-integration-test-ubuntu-main
/test metal3-dev-env-integration-test-centos-main

@mquhuy
Copy link
Member Author

mquhuy commented Aug 14, 2024

/retest

@mquhuy
Copy link
Member Author

mquhuy commented Aug 15, 2024

/test metal3-dev-env-integration-test-ubuntu-main
/test metal3-dev-env-integration-test-centos-main

@mquhuy
Copy link
Member Author

mquhuy commented Aug 15, 2024

/retest

4 similar comments
@mquhuy
Copy link
Member Author

mquhuy commented Aug 16, 2024

/retest

@mquhuy
Copy link
Member Author

mquhuy commented Aug 16, 2024

/retest

@mquhuy
Copy link
Member Author

mquhuy commented Aug 20, 2024

/retest

@mquhuy
Copy link
Member Author

mquhuy commented Aug 21, 2024

/retest

@mquhuy
Copy link
Member Author

mquhuy commented Sep 3, 2024

/test metal3-dev-env-integration-test-ubuntu-main
/test metal3-dev-env-integration-test-centos-main

@mquhuy
Copy link
Member Author

mquhuy commented Sep 3, 2024

/retest

@mquhuy
Copy link
Member Author

mquhuy commented Sep 16, 2024

/test metal3-dev-env-integration-test-ubuntu-main
/test metal3-dev-env-integration-test-centos-main

@mquhuy
Copy link
Member Author

mquhuy commented Sep 16, 2024

/retest

@mquhuy
Copy link
Member Author

mquhuy commented Sep 16, 2024

Deploy-CLI was merged. Repurposing this PR as adaptation of the new tool to dev-env.

/retitle 🌱 Take Deploy-cli to replace deploy.sh

@metal3-io-bot metal3-io-bot changed the title DO NOT MERGE Test Deploy-cli 🌱 Take Deploy-cli to replace deploy.sh Sep 16, 2024
@mquhuy
Test Deploy-cli
8a8a8e6 
Signed-off-by: Huy Mai <[email protected]>
@mquhuy
Copy link
Member Author

mquhuy commented Sep 16, 2024

/test metal3-dev-env-integration-test-ubuntu-main
/test metal3-centos-e2e-integration-test-release-1-8

@mquhuy
Copy link
Member Author

mquhuy commented Sep 17, 2024

/retest

4 similar comments
@mquhuy
Copy link
Member Author

mquhuy commented Sep 17, 2024

/retest

@tuminoid
Copy link
Member

/retest

@tuminoid
Copy link
Member

/retest

@mquhuy
Copy link
Member Author

mquhuy commented Oct 17, 2024

/retest

@metal3-io-bot
Copy link
Collaborator

@mquhuy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-centos-e2e-integration-test-release-1-8 8a8a8e6 link true /test metal3-centos-e2e-integration-test-release-1-8

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@metal3-io-bot
Copy link
Collaborator

@mquhuy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-centos-e2e-integration-test-release-1-8 8a8a8e6 link true /test metal3-centos-e2e-integration-test-release-1-8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elfosardo elfosardo Awaiting requested review from elfosardo

@tuminoid tuminoid Awaiting requested review from tuminoid

@dtantsur dtantsur Awaiting requested review from dtantsur

@kashifest kashifest Awaiting requested review from kashifest

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mquhuy @metal3-io-bot @tuminoid