Add option to run Dev-env with FakeIPA #1450
Open
+122
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
size/M
mboukhalfa
force-pushed
the
Integrate-fakeIPA/mohammed
branch
from
e270b37
to
54833a3
Compare
metal3-io-bot
added
size/L
mboukhalfa
force-pushed
the
Integrate-fakeIPA/mohammed
branch
2 times, most recently
from
faf54fb
to
f4a3e4d
Compare
metal3-io-bot
removed
the
do-not-merge/work-in-progress
mboukhalfa
force-pushed
the
Integrate-fakeIPA/mohammed
branch
2 times, most recently
from
5047112
to
fd4cf65
Compare
mboukhalfa
force-pushed
the
Integrate-fakeIPA/mohammed
branch
4 times, most recently
from
200867f
to
84aba16
Compare
tuminoid
reviewed
Sep 20, 2024
| # wait for ironic to be running | ||
| kubectl -n baremetal-operator-system wait --for=condition=available deployment/baremetal-operator-ironic --timeout=300s | ||
| mkdir -p /opt/metal3-dev-env/fake-ipa | ||
| kubectl -n legacy get secret -n baremetal-operator-system ironic-cert -o json -o=jsonpath="{.data.ca\.crt}" | base64 -d > /opt/metal3-dev-env/fake-ipa/ironic-ca.crt |
There was a problem hiding this comment.
Suggested change
| kubectl -n legacy get secret -n baremetal-operator-system ironic-cert -o json -o=jsonpath="{.data.ca\.crt}" | base64 -d > /opt/metal3-dev-env/fake-ipa/ironic-ca.crt | |
| kubectl -n legacy get secret -n baremetal-operator-system ironic-cert -o json -o=jsonpath="{.data.ca\.crt}" | base64 -d > /opt/metal3-dev-env/fake-ipa/ironic-ca.crt |
| metadata: | ||
| name: default-node-2-bmc-secret | ||
| labels: | ||
| environment.metal3.io: baremetal |
There was a problem hiding this comment.
Suggested change
| environment.metal3.io: baremetal | |
| environment.metal3.io: baremetal |
| bootMode: legacy | ||
| EOF | ||
| kubectl apply -f "${WORKING_DIR}/bmhosts_crs.yaml" -n "$NAMESPACE" | ||
| else | ||
| apply_bm_hosts "$NAMESPACE" |
There was a problem hiding this comment.
Suggested change
| apply_bm_hosts "$NAMESPACE" | |
| apply_bm_hosts "$NAMESPACE" |
| @@ -538,7 +538,69 @@ if [ "${EPHEMERAL_CLUSTER}" != "tilt" ]; then | |||
| # Thus we are deleting validatingwebhookconfiguration resource if exists to let BMO is working properly on local runs. | |||
| kubectl delete validatingwebhookconfiguration/"${BMO_NAME_PREFIX}"-validating-webhook-configuration --ignore-not-found=true | |||
| fi | |||
| # if fake platform (no VMs) run FakeIPA | |||
There was a problem hiding this comment.
Suggested change
| # if fake platform (no VMs) run FakeIPA | |
| # if fake platform (no VMs) run FakeIPA |
| metadata: | ||
| name: default-node-1-bmc-secret | ||
| labels: | ||
| environment.metal3.io: baremetal |
There was a problem hiding this comment.
Suggested change
| environment.metal3.io: baremetal | |
| environment.metal3.io: baremetal |
| bootMACAddress: 00:5c:52:31:3a:9d | ||
| bootMode: legacy | ||
| EOF | ||
| kubectl apply -f "${WORKING_DIR}/bmhosts_crs.yaml" -n "$NAMESPACE" |
There was a problem hiding this comment.
Suggested change
| kubectl apply -f "${WORKING_DIR}/bmhosts_crs.yaml" -n "$NAMESPACE" | |
| kubectl apply -f "${WORKING_DIR}/bmhosts_crs.yaml" -n "$NAMESPACE" |
| apply_bm_hosts "$NAMESPACE" | ||
| fi | ||
| elif [ "${EPHEMERAL_CLUSTER}" == "tilt" ]; then | ||
|
|
||
| source tilt-setup/deploy_tilt_env.sh |
There was a problem hiding this comment.
Suggested change
| source tilt-setup/deploy_tilt_env.sh | |
| source tilt-setup/deploy_tilt_env.sh |
| apply_bm_hosts "$NAMESPACE" | ||
| fi | ||
| elif [ "${EPHEMERAL_CLUSTER}" == "tilt" ]; then | ||
|
|
Signed-off-by: Mohammed Boukhalfa <[email protected]>
mboukhalfa
force-pushed
the
Integrate-fakeIPA/mohammed
branch
from
84aba16
to
6d6b7ed
Compare
tuminoid
reviewed
Sep 23, 2024
| @@ -181,6 +181,9 @@ EOF | |||
| echo "DHCP_HOSTS=${DHCP_HOSTS}" | sudo tee -a "${IRONIC_DATA_DIR}/ironic_bmo_configmap.env" | |||
| fi | |||
|
|
|||
| if [ "${VM_PLATFORM}" == "fake" ]; then | |||
There was a problem hiding this comment.
Suggested change
| if [ "${VM_PLATFORM}" == "fake" ]; then | |
| if [[ "${VM_PLATFORM}" == "fake" ]]; then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run environment to test scalability with FakeIPA
To enable fakeIPA in devenv add the following lines to the config file