Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Remove release 1.5 branch config #1451

Merged
merged 1 commit into from
Sep 13, 2024
Merged

🌱 Remove release 1.5 branch config #1451

merged 1 commit into from
Sep 13, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Aug 28, 2024 •
edited
Loading

This PR removes release-1.5 related config, fixes BMO version and ironic-image versions, as ironic release-26.0 is out now.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2024
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 28, 2024
tuminoid
tuminoid reviewed Aug 28, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is both adding and removing releases in same PR again.

@mquhuy
Copy link
Member Author

mquhuy commented Aug 28, 2024

This is both adding and removing releases in same PR again.

This is meant to be rebased after #1443 is merged.

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Aug 29, 2024
@mquhuy mquhuy force-pushed the mquhuy/remove-release-1.5-branch-config branch from 8aaf0eb to ba8c377 Compare September 9, 2024 09:29
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2024
tuminoid
tuminoid reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VARS.md also references BMO 0.4, needs update.

lib/common.sh Outdated Show resolved Hide resolved
vm-setup/install-package-playbook.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@mquhuy mquhuy force-pushed the mquhuy/remove-release-1.5-branch-config branch 5 times, most recently from 46cc31e to 6f697c4 Compare September 9, 2024 09:56
tuminoid
tuminoid reviewed Sep 9, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@mquhuy mquhuy force-pushed the mquhuy/remove-release-1.5-branch-config branch from 6f697c4 to a00e5ed Compare September 12, 2024 11:13
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 12, 2024
smoshiur1237
smoshiur1237 reviewed Sep 12, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2024
tuminoid
tuminoid reviewed Sep 13, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/unhold

@metal3-io-bot metal3-io-bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 13, 2024
@tuminoid
Copy link
Member

/override metal3-centos-e2e-integration-test-release-1-8
/test metal3-dev-env-integration-test-ubuntu-main

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-release-1-8

In response to this:

/override metal3-centos-e2e-integration-test-release-1-8
/test metal3-dev-env-integration-test-ubuntu-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid
Copy link
Member

/retest

@metal3-io-bot metal3-io-bot merged commit 5a96750 into metal3-io:main Sep 13, 2024
6 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/remove-release-1.5-branch-config branch September 13, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

@tuminoid tuminoid tuminoid left review comments

@elfosardo elfosardo Awaiting requested review from elfosardo

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mquhuy @metal3-io-bot @tuminoid @smoshiur1237