Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Metal3 Remediation section #462

Merged

Conversation

clobrano
Copy link
Contributor

@clobrano clobrano commented Jul 29, 2024

Update the Metal3 Remediation section with the new step Out-of-Service
taint replacing node deletion.

See metal3-io/cluster-api-provider-metal3#1808

@clobrano clobrano force-pushed the metal3remediation-update-with-oost-0 branch from 12b2955 to 49a2ef0 Compare July 29, 2024 08:30
Update the Metal3 Remediation section with the new step Out-of-Service
taint replacing node deletion.

See metal3-io/cluster-api-provider-metal3#1808

Signed-off-by: Carlo Lobrano <[email protected]>
@clobrano clobrano force-pushed the metal3remediation-update-with-oost-0 branch from 49a2ef0 to a3648ae Compare July 29, 2024 08:31
@metal3-io-bot metal3-io-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 29, 2024
@metal3-io-bot
Copy link
Contributor

Hi @clobrano. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid
Copy link
Member

tuminoid commented Aug 5, 2024

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 5, 2024
@tuminoid
Copy link
Member

/cc @Rozzii @kashifest @adilGhaffarDev

@kashifest
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2024
@tuminoid
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2024
@metal3-io-bot metal3-io-bot merged commit 0199331 into metal3-io:main Aug 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants