-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Regroup prow config tests by names #843
🌱 Regroup prow config tests by names #843
Conversation
/test metal3-ubuntu-e2e-integration-test-main |
Can you do the regrouping in one PR and 1.8 addition in another, or at least put them in two commits? |
Signed-off-by: Huy Mai <[email protected]>
fa95e3d
to
69b794f
Compare
Yes, sorry. It was the intention, but I didn't manage to delete all release-1.8 reference. I updated the PR now. |
We can already remove 1.5 tests. |
The purpose of this PR is just to rearrange the tests, not adding/removing anything. The adding of release-1.8 and removal of release-1.5 will happen in consequent PRs. Btw, in the daily we decided that from now on, adding new release branch and deleting the EOL one from config will happen in 2 different PRs. |
/test metal3-ubuntu-e2e-integration-test-main |
/override metal3-ubuntu-e2e-integration-test-main |
@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Oh you have this regrouping in two PRs now. OK, the other one is probably meant to rebase on top of this.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@mquhuy: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Most of tests in prow config file are grouped by the test names, but some of them are currently grouped by branch names (for e.g.
metal3-centos-e2e-feature-test-release-1-7-pivoting
is grouped withmetal3-centos-e2e-feature-test-release-1-7-features
, instead ofmetal3-centos-e2e-feature-test-main-pivoting
). This makes it difficult to manage the tests, for e.g. when adding/removing test branches.This PR regroups the tests so that all of them are grouped by tests.