Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Regroup prow config tests by names #843

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Aug 28, 2024

Most of tests in prow config file are grouped by the test names, but some of them are currently grouped by branch names (for e.g. metal3-centos-e2e-feature-test-release-1-7-pivoting is grouped with metal3-centos-e2e-feature-test-release-1-7-features, instead of metal3-centos-e2e-feature-test-main-pivoting). This makes it difficult to manage the tests, for e.g. when adding/removing test branches.

This PR regroups the tests so that all of them are grouped by tests.

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 28, 2024
@mquhuy mquhuy changed the title 🌱 Regroup prow config by tests 🌱 Regroup prow config tests by names Aug 28, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Aug 28, 2024

/test metal3-ubuntu-e2e-integration-test-main

@tuminoid
Copy link
Member

Can you do the regrouping in one PR and 1.8 addition in another, or at least put them in two commits?

@mquhuy
Copy link
Member Author

mquhuy commented Aug 28, 2024

Can you do the regrouping in one PR and 1.8 addition in another, or at least put them in two commits?

Yes, sorry. It was the intention, but I didn't manage to delete all release-1.8 reference. I updated the PR now.

@Sunnatillo
Copy link
Member

We can already remove 1.5 tests.

@mquhuy
Copy link
Member Author

mquhuy commented Aug 28, 2024

We can already remove 1.5 tests.

The purpose of this PR is just to rearrange the tests, not adding/removing anything. The adding of release-1.8 and removal of release-1.5 will happen in consequent PRs.

Btw, in the daily we decided that from now on, adding new release branch and deleting the EOL one from config will happen in 2 different PRs.

@mquhuy
Copy link
Member Author

mquhuy commented Aug 28, 2024

/test metal3-ubuntu-e2e-integration-test-main

@tuminoid
Copy link
Member

/override metal3-ubuntu-e2e-integration-test-main
this does nothing

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main
this does nothing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Oh you have this regrouping in two PRs now. OK, the other one is probably meant to rebase on top of this.

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2024
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2024
@metal3-io-bot metal3-io-bot merged commit 908ce40 into metal3-io:main Aug 28, 2024
5 checks passed
@metal3-io-bot
Copy link
Collaborator

@mquhuy: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/manifests/overlays/metal3/config.yaml

In response to this:

Most of tests in prow config file are grouped by the test names, but some of them are currently grouped by branch names (for e.g. metal3-centos-e2e-feature-test-release-1-7-pivoting is grouped with metal3-centos-e2e-feature-test-release-1-7-features, instead of metal3-centos-e2e-feature-test-main-pivoting). This makes it difficult to manage the tests, for e.g. when adding/removing test branches.

This PR regroups the tests so that all of them are grouped by tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants