Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump ingress-nginx in prow to v1.10.4 #857

Merged
merged 1 commit into from
Sep 13, 2024
Merged

🌱 Bump ingress-nginx in prow to v1.10.4 #857

merged 1 commit into from
Sep 13, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Sep 13, 2024

Bump Ingress-Nginx to v1.10.4 because of a severity CVE on v1.10.1

This PR also:

  • Fix cloud reference in prow README
  • Update prow overlays to new kustomize syntax.

@kashifest
Copy link
Member

/retitle 🌱 Bump Ingress Nginx in prow v1.10.4

@metal3-io-bot metal3-io-bot changed the title 🌱 Bump Ingress Nginx in prow 🌱 Bump Ingress Nginx in prow v1.10.4 Sep 13, 2024
@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 13, 2024
@mquhuy mquhuy force-pushed the mquhuy/upgrade-ingress-nginx-prow branch from 4dd5939 to 62c45ba Compare September 13, 2024 11:33
@kashifest
Copy link
Member

/retitle 🌱 Bump ingress-nginx in prow to v1.10.4

@metal3-io-bot metal3-io-bot changed the title 🌱 Bump Ingress Nginx in prow v1.10.4 🌱 Bump ingress-nginx in prow to v1.10.4 Sep 13, 2024
kashifest
kashifest reviewed Sep 13, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2024
tuminoid
tuminoid reviewed Sep 13, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Has this been applied already?

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2024
@tuminoid
Copy link
Member

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot merged commit 2f68840 into metal3-io:main Sep 13, 2024
7 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/upgrade-ingress-nginx-prow branch September 13, 2024 11:48
@mquhuy
Copy link
Member Author

mquhuy commented Sep 13, 2024

/lgtm

Has this been applied already?

Yes it has

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@tuminoid tuminoid tuminoid left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mquhuy @kashifest @metal3-io-bot @tuminoid