Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow uploading the latest image under a common name #858

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

kashifest
Copy link
Member

@kashifest kashifest commented Sep 16, 2024

This PR makes sure that the latest image created in Openstack is pushed under a common name. This will make sure that the image being used in Jenkins workers remain active all the time. When replacing an old image with the latest, this commit also renames the old image based on its original name which is build date suffixed and this will be added in the images as an image_name property.

This PR makes sure that the latest image created in Openstack is pushed under a common name. This will make sure that the image being used in Jenkins workers remain active all the time. When replacing an old image with the latest, this commit also renames the old image based on its original name which is build date prefix and this will be added in the images as an image_name property.

Signed-off-by: Kashif Khan <[email protected]>
@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 16, 2024
@Rozzii
Copy link
Member

Rozzii commented Sep 16, 2024

/approve

@Rozzii
Copy link
Member

Rozzii commented Sep 16, 2024

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2024
@Rozzii
Copy link
Member

Rozzii commented Sep 16, 2024

/test metal3-ubuntu-e2e-integration-test-main

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

This is great, puts stop to Jenkins worker breakages. Thanks!

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rozzii, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
@metal3-io-bot metal3-io-bot merged commit a4b3614 into metal3-io:main Sep 16, 2024
7 checks passed
@metal3-io-bot metal3-io-bot deleted the kashif/fix-image-retention branch September 16, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants