Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide ipv6 interfaces by default #2895

Merged
merged 2 commits into from
Nov 6, 2024
Merged

hide ipv6 interfaces by default #2895

merged 2 commits into from
Nov 6, 2024

Conversation

aviramha
Copy link
Member

@aviramha aviramha commented Nov 6, 2024

Closes #2849

DmitryDodzin
DmitryDodzin approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@DmitryDodzin DmitryDodzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just maybe mention the deprecation in the changelog

mirrord-schema.json Show resolved Hide resolved
@aviramha
Copy link
Member Author

aviramha commented Nov 6, 2024

LGTM, just maybe mention the deprecation in the changelog

not relevant, it was already deprecated in previous release I just fixed the docs to show that.

@aviramha aviramha added this pull request to the merge queue Nov 6, 2024
Merged via the queue into metalbear-co:main with commit c8de576 Nov 6, 2024
17 checks passed
@aviramha aviramha deleted the experimental_true branch November 6, 2024 12:02
@aviramha aviramha mentioned this pull request Nov 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gememma gememma gememma left review comments

@DmitryDodzin DmitryDodzin DmitryDodzin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make hide_ipv6_interfaces on by default
3 participants
@aviramha @DmitryDodzin @gememma