Fix conflicting ARP when IP is shared #922
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When IP is shared by two services, it may be annonced from different nodes causing conflicting arp responses. This commit fixes by using service IP in the hash instead of service name so that service sharing the same IP will have the same master. For traffic cluster services, all nodes should be usable instead of those running pods, so that services sharing IPs have the same set of usable nodes.
|
This introduce 2 unneeded behavior change for all users:
Ideally changes in this PR should only impact shared IP services |
|
obsoleted by #976 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the changes purposed by @liuyuan10 in #562 and adapt them for latest version
v0.10.2We're using this patch in production for a few month, it works perfectly.
Fixes #558
docker images prepared: