Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added change parameter to bip44WithChange private key generator #117

Merged
merged 1 commit into from
Dec 2, 2022
Merged

added change parameter to bip44WithChange private key generator #117

merged 1 commit into from
Dec 2, 2022

Conversation

samdowd
Copy link
Contributor

@samdowd samdowd commented Nov 24, 2022

Description

Work Completed

  • added a parameter to getPrivateKeyFromSeed to allow consumers to use Bip44 with change

API Changes

  • added a parameter to getPrivateKeyFromSeed, but provided default value so non-breaking

@ajamaica
Copy link
Contributor

This is great. Thanks a lot for this contribution

@ajamaica ajamaica self-requested a review December 1, 2022 22:47
@ajamaica
Copy link
Contributor

ajamaica commented Dec 2, 2022

CI on actions is failing. I checked this on local looks.

@ajamaica ajamaica merged commit cb16800 into metaplex-foundation:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajamaica ajamaica Awaiting requested review from ajamaica

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Impossible to generate set of keypairs from mnemonic
2 participants
@samdowd @ajamaica