feat(module augmentations): augment umi module directly #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Umiinterface is augmented directly in its module file.Supposably it should fix problems with nested module augmentations. The problem appears when this DAS client is a peer dependency of some other package/client which also tries to augment the same thing, the
Umiinterface in this case. This leads to module override rather than augmentation and theUmiinterface loses its original properties such aspayer,identity,programsetc.P.S. It should be published as an alpha version (or use any other approach) to prevent people from updating right away and have some time to test it.