Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding edition_marker_v2 #1084

Closed
wants to merge 17 commits into from
Closed

Adding edition_marker_v2 #1084

wants to merge 17 commits into from

Conversation

blockiosaurus
Copy link
Contributor

This PR is a staging PR, for review only, that adds the edition marker subcomponent to Token Metadata.

Edition marker v2 is a simplification of the original edition marker. Rather than having bitfields stored in a sequence of marker PDAs, there is a single PDA which is resized to fit all of the editions.

danenbm
danenbm previously approved these changes May 10, 2023
View reviewed changes
@blockiosaurus
Merge branch 'master' of github.com:metaplex-foundation/metaplex-prog…
be6e77c 
…ram-library into stage/programmable-asset-editions
@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/5006544752.

@blockiosaurus @danenbm
@ethyi @febo @samuelvanderwaal
Adding Print Instruction (#1094)
6155fd9 
* chore: Release

* Update generated SDK and IDL versions for token-metadata 1.11.0 release

* Bubblegum collection docs fix (#1072)

* collection fix

* Revert "collection fix"

This reverts commit cbc20ca.

* change docs for bubblegum

* Allow for 5 creators in Bubblegum (#1086)

* Update token metadata dependency

* Allow data and is_immutable to be updated at same time (#1090)

* Added can_update_data_and_is_mutable_same_instruction to test.
* Also added a couple more tests to Update for other cases.

* Remove Old Testing CLI (#1089)

* remove old CLI

* add README to replace CLI

* chore: Release

* Update generated SDK and IDL versions for token-metadata 1.11.1 release

* Add missing delegate record error (#1093)

* Adding print instruction.

* Add delegate check on transfer (#1095)

* Test delegate status after transfer

* Add delegate check on transfer

* add migration role exception (#1096)

* Allow Bubblegum to create metadata with verified collection (#1087)

* Allow Bubblegum to create metadata with verified collection

* Use separate variable

* Fix ordering in collection verification

* Add test for verifying collection and decompressing
with verified collection.
* Add DigitalAsset from token-metadata in test utils
for creating a collection parent.
* Add needed helper objects such as VerifyCollectionBuilder,
as well as required local test tree updates.
* Fix some clippy issues in the contract.  There are still a
few more clippy issues in the tests but they are more involved.

* Cleanup comment

* Updating based on feedback.

* detect deprecated ixes and provide proper error (#1092)

* detect deprecated ixes and provide proper error

* run cargo fmt

* Removing comments.

* Adding UA check.

* Making code rustier and adding ME check.

* Box test utils err and remove RefCells from test objects (#1097)

* More minor simplifications to Bubblegum BPF tests (#1101)

* Making UA check work for any standard.

* Adding init check.

---------

Co-authored-by: Michael Danenberg <[email protected]>
Co-authored-by: ethyi <[email protected]>
Co-authored-by: Fernando Otero <[email protected]>
Co-authored-by: Samuel Vanderwaal <[email protected]>
@blockiosaurus
Merge branch 'master' of github.com:metaplex-foundation/metaplex-prog…
d217d1f 
…ram-library into stage/programmable-asset-editions
@blockiosaurus
Merge branch 'stage/programmable-asset-editions' of github.com:metapl…
3279fcb 
…ex-foundation/metaplex-program-library into stage/programmable-asset-editions
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/5189805990.

@blockiosaurus
Merge branch 'master' of github.com:metaplex-foundation/metaplex-prog…
484b509 
…ram-library into stage/programmable-asset-editions
@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/5258514888.

@blockiosaurus @danenbm
@febo @samuelvanderwaal
Add the ability to burn a ProgrammableNonfungibleEdition (#1108)
aafb639 
* Adding print instruction.

* Updating based on feedback.

* Removing comments.

* Adding UA check.

* Making code rustier and adding ME check.

* Making UA check work for any standard.

* Adding init check.

* Adding burn PR for pNFTEs

* Fixing burn byte offset.

* Adding escrows for pNFTs and removing check for closing the account. (#1110)

* Manually reducing size of Bubblegum IDL for publishing

* Setting Solana to exact version in Bubblegum

* Add operation list (#1098)

* Add operation list

* Update packages version

* Fix typo

* Add operation definition

* Typos

* chore: Release mpl-bubblegum version 0.8.0

* Update Bubblegum npm package version prior to publish

* Fixing in response to feedback.

* replace serialize with metadata save fn

* fix overwriting of fee flag on 'update' (#1114)

* fix overwriting of fee flag on 'update'

* fix index in clean write

---------

Co-authored-by: Michael Danenberg <[email protected]>
Co-authored-by: Fernando Otero <[email protected]>
Co-authored-by: Samuel Vanderwaal <[email protected]>
@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/5267330060.

@blockiosaurus
Adding fees and fixing merge errors. (#1116)
aa0e5a6 
* Adding fees and fixing merge errors.

* Adding token standard flag.
@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/5284101844.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/5487178507.

@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/5522849740.

@github-actions
Copy link
Contributor

Workflow Verify package library found differences when running yarn api:gen in the JS lib for token-metadata. Please see the job for more details: https://github.com/metaplex-foundation/metaplex-program-library/actions/runs/5522881724.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelvanderwaal samuelvanderwaal samuelvanderwaal left review comments

@danenbm danenbm danenbm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blockiosaurus @samuelvanderwaal @danenbm