Make mint account optional signer #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blockiosaurus
requested review from
febo and
svc01-metaplex
and removed request for
a team
…ex-foundation/metaplex-program-library into stage/programmable-asset-editions-mint-optional-signer
febo
approved these changes
Jul 12, 2023
blockiosaurus
deleted the
stage/programmable-asset-editions-mint-optional-signer
branch
blockiosaurus
added a commit
that referenced
this pull request
Jul 14, 2023
* Adding edition_marker_v2. * Adding marker seed. * Adding divisor to prevent overalloc. * Responding to feedback and fixing bug. * Adding Print Instruction (#1094) * chore: Release * Update generated SDK and IDL versions for token-metadata 1.11.0 release * Bubblegum collection docs fix (#1072) * collection fix * Revert "collection fix" This reverts commit cbc20ca. * change docs for bubblegum * Allow for 5 creators in Bubblegum (#1086) * Update token metadata dependency * Allow data and is_immutable to be updated at same time (#1090) * Added can_update_data_and_is_mutable_same_instruction to test. * Also added a couple more tests to Update for other cases. * Remove Old Testing CLI (#1089) * remove old CLI * add README to replace CLI * chore: Release * Update generated SDK and IDL versions for token-metadata 1.11.1 release * Add missing delegate record error (#1093) * Adding print instruction. * Add delegate check on transfer (#1095) * Test delegate status after transfer * Add delegate check on transfer * add migration role exception (#1096) * Allow Bubblegum to create metadata with verified collection (#1087) * Allow Bubblegum to create metadata with verified collection * Use separate variable * Fix ordering in collection verification * Add test for verifying collection and decompressing with verified collection. * Add DigitalAsset from token-metadata in test utils for creating a collection parent. * Add needed helper objects such as VerifyCollectionBuilder, as well as required local test tree updates. * Fix some clippy issues in the contract. There are still a few more clippy issues in the tests but they are more involved. * Cleanup comment * Updating based on feedback. * detect deprecated ixes and provide proper error (#1092) * detect deprecated ixes and provide proper error * run cargo fmt * Removing comments. * Adding UA check. * Making code rustier and adding ME check. * Box test utils err and remove RefCells from test objects (#1097) * More minor simplifications to Bubblegum BPF tests (#1101) * Making UA check work for any standard. * Adding init check. --------- Co-authored-by: Michael Danenberg <[email protected]> Co-authored-by: ethyi <[email protected]> Co-authored-by: Fernando Otero <[email protected]> Co-authored-by: Samuel Vanderwaal <[email protected]> * Add the ability to burn a ProgrammableNonfungibleEdition (#1108) * Adding print instruction. * Updating based on feedback. * Removing comments. * Adding UA check. * Making code rustier and adding ME check. * Making UA check work for any standard. * Adding init check. * Adding burn PR for pNFTEs * Fixing burn byte offset. * Adding escrows for pNFTs and removing check for closing the account. (#1110) * Manually reducing size of Bubblegum IDL for publishing * Setting Solana to exact version in Bubblegum * Add operation list (#1098) * Add operation list * Update packages version * Fix typo * Add operation definition * Typos * chore: Release mpl-bubblegum version 0.8.0 * Update Bubblegum npm package version prior to publish * Fixing in response to feedback. * replace serialize with metadata save fn * fix overwriting of fee flag on 'update' (#1114) * fix overwriting of fee flag on 'update' * fix index in clean write --------- Co-authored-by: Michael Danenberg <[email protected]> Co-authored-by: Fernando Otero <[email protected]> Co-authored-by: Samuel Vanderwaal <[email protected]> * Adding fees and fixing merge errors. (#1116) * Adding fees and fixing merge errors. * Adding token standard flag. * Adding delegate for pNFT editions. (#1130) * Adding fees for standard NFT editions. (#1131) * Adding supply and decimal checks. (#1132) * Adding mint checks. (#1140) * Removing tests built for statically sized accounts. * Generating the JS SDK. * Fixing burn tests and modifying the Edition close auth for utility delegate (#1144) * Fixing burn test issues. * Moving UA check up a level. * Fixing an old test. * Make mint account optional signer (#1146) * Fixing burn test issues. * Moving UA check up a level. * Fixing an old test. * Making the mint account an optional signer. * Removing commented out code. * Removing unnecessary error. * Regen JS --------- Co-authored-by: Michael Danenberg <[email protected]> Co-authored-by: ethyi <[email protected]> Co-authored-by: Fernando Otero <[email protected]> Co-authored-by: Samuel Vanderwaal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.