New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MessagePort leak #1886

Merged

tshemsedinov merged 1 commit into master from fix-mem-leak

Aug 3, 2023

Member

nechaido commented Aug 3, 2023 •

edited

Loading

Generally, it would be better to open only one MessagePort pair between main and worker threads. But this will fix a leak for now/

tests and linter show no problems (npm t)
tests are added/updated for bug fixes and new features
code is properly formatted (npm run fmt)
description of changes is added in CHANGELOG.md
update .d.ts typings

Here is the summery of the memory snapshots of a dev server after a few hours of running a scheduled task every 10s.

Without the fix:

With the fix:


          Fix MessagePort leak

a8ed607

nechaido requested a review from tshemsedinov

August 3, 2023 07:37

tshemsedinov approved these changes

View reviewed changes

tshemsedinov merged commit 675bd47 into master

12 checks passed

tshemsedinov deleted the fix-mem-leak branch

August 3, 2023 08:35

Member

tshemsedinov commented Aug 3, 2023

Related issue: #1740

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet