-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Move all the configs to one single file #733
Conversation
Signed-off-by: Yohe-Am <[email protected]>
Signed-off-by: Yohe-Am <[email protected]>
Signed-off-by: Yohe-Am <[email protected]>
Signed-off-by: Yohe-Am <[email protected]>
# Conflicts: # dev/Dockerfile # dev/lock.yml # rust-toolchain.toml
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #733 +/- ##
==========================================
- Coverage 73.40% 73.38% -0.03%
==========================================
Files 115 117 +2
Lines 14027 14143 +116
Branches 1416 1410 -6
==========================================
+ Hits 10297 10379 +82
- Misses 3704 3738 +34
Partials 26 26 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good diff.
b26f08b
to
eb379da
Compare
Typegate
instance, to improve test configurability.Migration notes
SYNC_REDIS_PASSWORD
has been removed, can only be set on theSYNC_REDIS_URL
.The change comes with new or modified tests
Hard-to-understand functions have explanatory comments
End-user documentation is updated to reflect the change