Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move all the configs to one single file #733

Merged
merged 52 commits into from
Jun 25, 2024

Conversation

Natoandro
Copy link
Contributor

@Natoandro Natoandro commented May 23, 2024

  • Move all the configs to one single file
  • Remove some specific configs from the global config variable and make them accessible on the Typegate instance, to improve test configurability.

Migration notes

  • SYNC_REDIS_PASSWORD has been removed, can only be set on the SYNC_REDIS_URL.

  • The change comes with new or modified tests

  • Hard-to-understand functions have explanatory comments

  • End-user documentation is updated to reflect the change

@Natoandro Natoandro marked this pull request as draft June 18, 2024 22:28
@Natoandro Natoandro marked this pull request as ready for review June 20, 2024 07:23
whiz.yaml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 84.83146% with 81 lines in your changes missing coverage. Please review.

Project coverage is 73.38%. Comparing base (41a84cc) to head (452769a).
Report is 2 commits behind head on main.

Files Patch % Lines
typegate/src/runtimes/wasm_wire.ts 0.00% 29 Missing ⚠️
typegate/src/config/loader.ts 79.06% 9 Missing ⚠️
typegate/src/config.ts 92.30% 7 Missing ⚠️
typegate/src/config/types.ts 89.85% 7 Missing ⚠️
typegate/src/services/auth/mod.ts 50.00% 7 Missing ⚠️
typegate/src/services/auth/protocols/oauth2.ts 82.35% 3 Missing ⚠️
typegate/src/typegate/mod.ts 85.00% 3 Missing ⚠️
typegate/tests/utils/query/rest_query.ts 57.14% 3 Missing ⚠️
typegate/src/log.ts 50.00% 2 Missing ⚠️
typegate/src/runtimes/typegate.ts 33.33% 2 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #733      +/-   ##
==========================================
- Coverage   73.40%   73.38%   -0.03%     
==========================================
  Files         115      117       +2     
  Lines       14027    14143     +116     
  Branches     1416     1410       -6     
==========================================
+ Hits        10297    10379      +82     
- Misses       3704     3738      +34     
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Yohe-Am
Yohe-Am previously approved these changes Jun 21, 2024
Copy link
Contributor

@Yohe-Am Yohe-Am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good diff.

@Natoandro Natoandro requested review from zifeo and Yohe-Am June 25, 2024 05:39
@Natoandro Natoandro merged commit 1076dce into main Jun 25, 2024
12 checks passed
@Natoandro Natoandro deleted the feat/met-521-unify-config branch June 25, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants