-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mdk)!: mdk_typescript
#739
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for another large PR ya'll. Didn't know how I could break this down.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #739 +/- ##
==========================================
+ Coverage 72.99% 73.10% +0.11%
==========================================
Files 117 116 -1
Lines 14181 14137 -44
Branches 1414 1417 +3
==========================================
- Hits 10351 10335 -16
+ Misses 3803 3775 -28
Partials 27 27 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, should the swc dependencies also be removed and also the post processing inside the typegate?
Another usecase was unfortunately discovered for the typescript crates here. To compile user provided typescript modules to javascript. (Deno also makes use of Note, these crates are no longer built by the thin cli. |
Yeah, that what I meant by the post processing on the type gate side, I believe there is no usage anymore: metatype/typegate/src/postprocess.ts Line 4 in 8dde1fa
|
a1701be
to
a4c32ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff 👍
mdk_typescript
code generator for typescript type inference on Deno runtime external modules.Migration notes
metatype.yaml
has changed. Targets are now lists instead of maps, items no sportinggenerator
field instead of key acting as ref to generator.fromExport
method has been renamed toexport
to make it more uniform to handler.export
andhandler
method's now expect handler/func name undername
instead offunc
.codegen
flag has been removed fromArtifactsConfig
object.gen mod/mdk
has been simplified to justgen
as the previous mod option is no longer avail.