Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: typegate in meta dev, upgrade test #776

Merged
merged 46 commits into from
Jul 5, 2024

Conversation

Natoandro
Copy link
Contributor

  • Test the typegate upgrade from the latest published version to the current version.
  • Add a flag to run an instance of the typegate with the target configuration (port, admin passsword) to meta deploy, enabled by default for meta dev.

Migration notes

If you have a script that runs meta dev, add the flag --no-typegate if you already have a typegate.

  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@Natoandro Natoandro force-pushed the feat/met-572-typegate-in-meta-dev branch from a424fd8 to bf84cbb Compare July 3, 2024 05:48
destifo
destifo previously approved these changes Jul 3, 2024
@Natoandro Natoandro force-pushed the feat/met-572-typegate-in-meta-dev branch 3 times, most recently from 7406464 to ab68679 Compare July 3, 2024 21:11
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 12 lines in your changes missing coverage. Please review.

Project coverage is 69.94%. Comparing base (f0402c1) to head (1f831a2).

Files Patch % Lines
typegate/tests/utils/hooks.ts 64.70% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
- Coverage   70.33%   69.94%   -0.40%     
==========================================
  Files         137      139       +2     
  Lines       16066    16175     +109     
  Branches     1472     1474       +2     
==========================================
+ Hits        11300    11313      +13     
- Misses       4741     4837      +96     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Natoandro Natoandro force-pushed the feat/met-572-typegate-in-meta-dev branch from ab68679 to 18da96b Compare July 4, 2024 04:53
@Yohe-Am Yohe-Am merged commit 1e3748b into main Jul 5, 2024
12 checks passed
@Yohe-Am Yohe-Am deleted the feat/met-572-typegate-in-meta-dev branch July 5, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants