Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare 0.4.6 #795

Merged
merged 22 commits into from
Aug 1, 2024
Merged

chore: prepare 0.4.6 #795

merged 22 commits into from
Aug 1, 2024

Conversation

Yohe-Am
Copy link
Contributor

@Yohe-Am Yohe-Am commented Jul 19, 2024

  • Bump version to 0.4.6-0
  • Add sanity tests for published SDKs
  • Bump deno to 1.45.2
  • Bump rust to 1.79.0
  • Fix myriad of bugs

Migration notes

...

  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

Summary by CodeRabbit

  • New Features

    • Introduced new logging capabilities in the ConnectedEngine with adjustable logging levels.
    • Implemented cleanup procedures in tests to enhance resource management.
  • Bug Fixes

    • Fixed import paths for permissions to ensure correct functionality in tests and applications.
  • Version Updates

    • Incremented version numbers across multiple projects and packages to reflect ongoing development and improvements.
  • Documentation

    • Added comments to clarify code behavior and potential future considerations in various modules.
  • Refactor

    • Optimized string handling in several functions and adjusted method signatures for improved clarity and efficiency.

zifeo
zifeo previously approved these changes Jul 20, 2024
@Yohe-Am
Copy link
Contributor Author

Yohe-Am commented Jul 21, 2024

@coderabbitai review

Copy link
Contributor

coderabbitai bot commented Jul 21, 2024

Walkthrough

The recent updates involve significant enhancements across multiple files, primarily focusing on version increments for various dependencies and the restructuring of certain components. Key changes include updates to platform specifications, dependency management, and the introduction of new features, such as improved cleanup mechanisms in tests and updated import paths. These modifications collectively aim to improve compatibility, maintainability, and functionality throughout the codebase.

Changes

File Paths Change Summary
.ghjk/lock.json, Cargo.toml, dev/Dockerfile, dev/consts.ts, and others Version increments for dependencies, including updates to Rust and Deno versions. New dependencies added and deprecated ones removed.
dev/deps.ts, dev/installs.ts, dev/tasks-dev.ts, dev/tasks-lock.ts, dev/tasks-test.ts Modifications to import paths and task definitions, enhancing resource management and cleanup procedures in tests.
dev/test.ts, libs/deno/src/lib.rs, libs/metagen/src/mdk/mod.rs Structural changes to handle subprocess management and permissions, along with added fields for improved functionality.
typegraph/core/Cargo.toml, typegraph/core/src/global_store.rs Version updates reflecting ongoing development and potential pre-release iterations for the typegraph package.
typegate/*, meta-cli/*, typegraph/python/*, and others Various updates to versioning in multiple modules and packages, including Python and Rust-related files, indicating new iterations and enhancements.

Sequence Diagram(s)

sequenceDiagram
    participant A as User
    participant B as Test Framework
    participant C as Resource Manager
    participant D as Codebase

    A->>B: Initiate Test
    B->>C: Setup Resources
    C->>D: Prepare Environment
    D-->>C: Environment Ready
    C-->>B: Resources Ready
    B->>D: Execute Tests
    D-->>B: Return Results
    B->>C: Cleanup Resources
    C-->>A: Test Completed
Loading
sequenceDiagram
    participant A as User
    participant B as CLI Tool
    participant C as Download Manager

    A->>B: Request CLI Download
    B->>C: Download and Extract CLI
    C-->>B: Download Complete
    B-->>A: CLI Ready for Use
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

zifeo
zifeo previously approved these changes Jul 21, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Outside diff range, codebase verification and nitpick comments (4)
libs/metagen/src/mdk/mod.rs (1)

14-18: Add a comment explaining the future use of the runtime field.

The runtime field is marked as unused, which might lead to confusion. Adding a comment explaining its future use would be helpful.

pub struct StubbedFunction {
    #[allow(unused)]
    pub id: u32,
    pub node: TypeNode,
    pub mat: Materializer,
    #[allow(unused)]
+   // The runtime field is added for future use in runtime management.
    pub runtime: Rc<TGRuntime>,
}
typegraph/core/src/utils/archive.rs (1)

Line range hint 60-69: Functionality temporarily disabled.

The unpack_base64 method in the implementation of ArchiveExt for FsContext has been commented out, indicating this functionality is temporarily disabled. The TODO comment suggests further development is needed.

Do you need help implementing the iterator to manage memory more efficiently?

meta-cli/src/deploy/actors/task/deploy/migrations.rs (1)

Line range hint 204-208:
Address the FIXME comment and remove the #[allow(unused)] attribute if possible.

The FIXME comment indicates that further attention is needed. The #[allow(unused)] attribute suggests that the struct is currently unused. Ensure that this struct is integrated into the codebase or remove it if it is not needed.

typegate/tests/e2e/published/published_test.ts (1)

Ensure robust error handling in downloadAndExtractCli calls.

The calls to downloadAndExtractCli in typegate/tests/e2e/published/published_test.ts are not wrapped in any error handling mechanisms. This can lead to unhandled exceptions and unexpected behavior. It is recommended to wrap these calls in try-catch blocks or implement appropriate error handling.

  • File: typegate/tests/e2e/published/published_test.ts
  • Lines: Instances found around lines 75 and 81
Analysis chain

Line range hint 78-122:
Ensure robust error handling in downloadAndExtractCli.

The function is well-structured, but it is important to ensure that all potential errors are handled properly, especially in asynchronous operations.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `downloadAndExtractCli` handle errors properly.

# Test: Search for the function usage. Expect: Proper error handling in all occurrences.
rg --type typescript -A 5 $'downloadAndExtractCli'

Length of output: 84


Script:

#!/bin/bash
# Description: Verify all function calls to `downloadAndExtractCli` handle errors properly.

# Test: Search for the function usage. Expect: Proper error handling in all occurrences.
rg --glob '*.ts' -A 5 $'downloadAndExtractCli'

Length of output: 1624


Script:

#!/bin/bash
# Description: Verify error handling around calls to `downloadAndExtractCli`.

# Test: Search for the function usage and fetch more context to check for error handling.
rg --glob '*.ts' -A 10 -B 5 $'downloadAndExtractCli'

Length of output: 3887

dev/tasks-test.ts Show resolved Hide resolved
typegate/tests/e2e/cli/dev_test.ts Show resolved Hide resolved
typegraph/core/src/utils/archive.rs Show resolved Hide resolved
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 60.78431% with 80 lines in your changes missing coverage. Please review.

Project coverage is 69.59%. Comparing base (25d5c24) to head (c77b1bc).

Files Patch % Lines
typegate/tests/utils/[email protected] 54.94% 41 Missing ⚠️
typegate/tests/utils/mock_fetch.ts 59.13% 38 Missing ⚠️
dev/utils.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #795      +/-   ##
==========================================
- Coverage   69.92%   69.59%   -0.33%     
==========================================
  Files         139      142       +3     
  Lines       16181    16466     +285     
  Branches     1475     1473       -2     
==========================================
+ Hits        11314    11459     +145     
- Misses       4842     4982     +140     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zifeo
zifeo previously approved these changes Jul 23, 2024
michael-0acf4
michael-0acf4 previously approved these changes Jul 23, 2024
Natoandro
Natoandro previously approved these changes Jul 23, 2024
examples/templates/deno/api/example.ts Outdated Show resolved Hide resolved
typegate/tests/e2e/published/published_test.ts Outdated Show resolved Hide resolved
@Yohe-Am Yohe-Am dismissed stale reviews from Natoandro, michael-0acf4, and zifeo via cdcb130 July 24, 2024 00:10
Natoandro
Natoandro previously approved these changes Jul 24, 2024
@Yohe-Am Yohe-Am changed the title chore: prepare 0.4.6-0 chore: prepare 0.4.6 Jul 25, 2024
zifeo
zifeo previously approved these changes Jul 25, 2024
Natoandro
Natoandro previously approved these changes Jul 29, 2024
@Yohe-Am Yohe-Am merged commit 4c30067 into main Aug 1, 2024
12 checks passed
@Yohe-Am Yohe-Am deleted the chore/prepare-0.4.6-0 branch August 1, 2024 08:36
Yohe-Am added a commit that referenced this pull request Aug 7, 2024
commit 25d96a8
Author: Yohe-Am <[email protected]>
Date:   Wed Aug 7 07:21:33 2024 +0300

    refactor: PreparedArgs api

commit 278bc09
Author: Yohe-Am <[email protected]>
Date:   Wed Aug 7 03:10:16 2024 +0300

    test: alias tests

commit 8ff17ec
Author: Yohe-Am <[email protected]>
Date:   Fri Aug 2 08:46:56 2024 +0300

    fix: test

commit 62d534d
Merge: d1c532e 4c30067
Author: Yohe-Am <[email protected]>
Date:   Fri Aug 2 06:46:33 2024 +0300

    Merge branch 'main' into feat/MET-567/python-gen-client

commit d1c532e
Author: Yohe-Am <[email protected]>
Date:   Fri Aug 2 04:30:28 2024 +0300

    tests: client_py

commit 676bdb8
Author: Yohe-Am <[email protected]>
Date:   Fri Aug 2 03:58:03 2024 +0300

    tests: client_py

commit 4c30067
Author: Yohe-Am <[email protected]>
Date:   Thu Aug 1 11:36:14 2024 +0300

    chore: prepare 0.4.6 (#795)

    - Bump version to 0.4.6-0
    - Add sanity tests for published SDKs
    - Bump deno to 1.45.2
    - Bump rust to 1.79.0
    - Fix myriad of bugs

    #### Migration notes

    ...

    - [x] The change comes with new or modified tests
    - [ ] Hard-to-understand functions have explanatory comments
    - [ ] End-user documentation is updated to reflect the change

    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->

    ## Summary by CodeRabbit

    - **New Features**
    - Introduced new logging capabilities in the `ConnectedEngine` with
    adjustable logging levels.
    - Implemented cleanup procedures in tests to enhance resource
    management.

    - **Bug Fixes**
    - Fixed import paths for permissions to ensure correct functionality in
    tests and applications.

    - **Version Updates**
    - Incremented version numbers across multiple projects and packages to
    reflect ongoing development and improvements.

    - **Documentation**
    - Added comments to clarify code behavior and potential future
    considerations in various modules.

    - **Refactor**
    - Optimized string handling in several functions and adjusted method
    signatures for improved clarity and efficiency.

    <!-- end of auto-generated comment: release notes by coderabbit.ai -->

commit f0ecfb5
Author: Yohe-Am <[email protected]>
Date:   Thu Aug 1 08:01:10 2024 +0300

    wip: wip

commit a48203a
Author: Yohe-Am <[email protected]>
Date:   Thu Aug 1 06:15:12 2024 +0300

    wip: wip

commit bfee2f2
Author: Yohe-Am <[email protected]>
Date:   Thu Aug 1 05:22:51 2024 +0300

    wip: wip

commit e57c322
Author: Yohe-Am <[email protected]>
Date:   Wed Jul 31 19:16:23 2024 +0300

    wip: wip

commit f55a3e7
Author: Yohe-Am <[email protected]>
Date:   Wed Jul 31 13:37:01 2024 +0300

    wip: wip

commit 25d5c24
Author: FITAHIANA Nomeniavo joe <[email protected]>
Date:   Thu Jul 25 20:59:22 2024 +0300

    feat:  better arg split logic for MCLI_LOADER (#799)

    <!--
    Pull requests are squashed and merged using:
    - their title as the commit message
    - their description as the commit body

    Having a good title and description is important for the users to get
    readable changelog.
    -->

    <!-- 1. Explain WHAT the change is about -->

    -

    <!-- 2. Explain WHY the change cannot be made simpler -->

    -

    <!-- 3. Explain HOW users should update their code -->

    #### Migration notes

    ...

    - [ ] The change comes with new or modified tests
    - [ ] Hard-to-understand functions have explanatory comments
    - [ ] End-user documentation is updated to reflect the change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants