Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(gate): use stream during artifact upload to s3 #841

Merged
merged 13 commits into from
Sep 16, 2024
Merged

refactor(gate): use stream during artifact upload to s3 #841

merged 13 commits into from
Sep 16, 2024

Conversation

destifo
Copy link
Contributor

@destifo destifo commented Sep 9, 2024

Migration notes

...

  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@destifo destifo changed the title refactor: use stream during artifact upload to s3 refactor(gate): use stream during artifact upload to s3 Sep 9, 2024
@destifo destifo self-assigned this Sep 9, 2024
Natoandro
Natoandro previously approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@Natoandro Natoandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

zifeo
zifeo reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@zifeo zifeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

import_map.json Outdated Show resolved Hide resolved
src/typegate/src/typegate/artifacts/shared.ts Show resolved Hide resolved
src/typegate/src/typegate/artifacts/shared.ts Outdated Show resolved Hide resolved
Base automatically changed from refactor/improve-missing-env-var-err to main September 9, 2024 08:40
@destifo destifo dismissed Natoandro’s stale review September 9, 2024 08:40

The base branch was changed.

@codecov Codecov
Copy link

codecov bot commented Sep 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.41%. Comparing base (8da5053) to head (4ecff69).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #841      +/-   ##
==========================================
+ Coverage   76.06%   76.41%   +0.34%     
==========================================
  Files         144      144              
  Lines       16715    16705      -10     
  Branches     1646     1646              
==========================================
+ Hits        12715    12765      +50     
+ Misses       3977     3921      -56     
+ Partials       23       19       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@destifo destifo merged commit 70a4d49 into main Sep 16, 2024
13 checks passed
@destifo destifo deleted the fix/s3-upload-to-stream branch September 16, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Natoandro Natoandro Natoandro approved these changes

@michael-0acf4 michael-0acf4 Awaiting requested review from michael-0acf4

@Yohe-Am Yohe-Am Awaiting requested review from Yohe-Am

@j03-dev j03-dev Awaiting requested review from j03-dev

@luckasRanarison luckasRanarison Awaiting requested review from luckasRanarison

@zifeo zifeo Awaiting requested review from zifeo

Assignees

@destifo destifo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@destifo @zifeo @Natoandro