Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subs,gate): port agent concept #845

Merged
merged 11 commits into from
Sep 24, 2024
Merged

feat(subs,gate): port agent concept #845

merged 11 commits into from
Sep 24, 2024

Conversation

michael-0acf4
Copy link
Contributor

@michael-0acf4 michael-0acf4 commented Sep 11, 2024

Continuation of #844

Note:
There is currently no need for additional flags when running typegate, existing runs should be picked automatically as long as the typegraph owning the workflow is deployed. SubstantialRuntime will launch and start the agent, the later will attempt to 'pick' jobs on the backend and spawn workers if it can acquire it.
Workflows are identified relative to their names for now, the content hash might be the way to go going forward, downside being that it will change even on smaller modifications (e.g. spaces, missing semicolons, ..).

Migration notes

None

  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 88.14815% with 64 lines in your changes missing coverage. Please review.

Project coverage is 77.08%. Comparing base (c56803c) to head (4b0b13e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/typegate/src/runtimes/substantial/agent.ts 83.58% 54 Missing ⚠️
src/typegate/src/runtimes/substantial.ts 96.27% 7 Missing ⚠️
...rc/runtimes/substantial/workflow_worker_manager.ts 86.95% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #845      +/-   ##
==========================================
+ Coverage   77.04%   77.08%   +0.04%     
==========================================
  Files         147      148       +1     
  Lines       17226    17509     +283     
  Branches     1697     1721      +24     
==========================================
+ Hits        13271    13497     +226     
- Misses       3936     3993      +57     
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-0acf4
Copy link
Contributor Author

I will tackle Redis + making POLL_INTERVAL_SECONDS and LEASE_LIFESPAN_SECONDS configurable in another PR.

Base automatically changed from substantial-integration to main September 23, 2024 13:18
@michael-0acf4 michael-0acf4 merged commit ee0b2c4 into main Sep 24, 2024
13 checks passed
@michael-0acf4 michael-0acf4 deleted the adapt-as-agent branch September 24, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants