Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sdk)!: remove index based names #848

Merged
merged 10 commits into from
Sep 23, 2024

Conversation

Yohe-Am
Copy link
Contributor

@Yohe-Am Yohe-Am commented Sep 18, 2024

  • Replace index based names for types by one that relies on type context in graph
  • Tests for type deduplication

Migration notes

TODO

  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

Copy link

linear bot commented Sep 18, 2024

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.26%. Comparing base (c31e20c) to head (dbc3bbd).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #848      +/-   ##
==========================================
- Coverage   76.48%   76.26%   -0.23%     
==========================================
  Files         145      145              
  Lines       16796    16796              
  Branches     1654     1649       -5     
==========================================
- Hits        12847    12810      -37     
- Misses       3930     3967      +37     
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Natoandro Natoandro merged commit 15c1afa into main Sep 23, 2024
12 of 13 checks passed
@Natoandro Natoandro deleted the met-654-sdk-remove-index-based-titles branch September 23, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants