refactor: Remove runtime field from TypeNode
#858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Natoandro
requested review from
Yohe-Am,
j03-dev,
michael-0acf4 and
zifeo
and removed request for
Yohe-Am and
j03-dev
# Conflicts: # src/meta-cli/src/cli/serialize.rs
Yohe-Am
approved these changes
Oct 2, 2024
Yohe-Am
approved these changes
Oct 10, 2024
7 tasks
|
Reproduced in #871. |
Natoandro
added a commit
that referenced
this pull request
Oct 22, 2024
- [MET-682](https://linear.app/metatypedev/issue/MET-682/move-all-injection-data-to-tfunc) - [x] Move all injection data in `ObjectTypeData` (i.e. `t.func`) - [MET-656](https://linear.app/metatypedev/issue/MET-656/sdk-improve-generated-titles-from-applyreduce) - [x] Translate reduce to injection specification on `t.func` - [MET-94](https://linear.app/metatypedev/issue/MET-94/remove-runtime-field-from-typenode) - [x] Remove runtime field from `TypeNode` (#858) - [MET-683](https://linear.app/metatypedev/issue/MET-683/move-runtime-related-type-configs-out-of-typenode) - [x] Move runtime-related configs to `MaterializerData` or `RuntimeData` - Misc. - Enable random ports for the typegate (when `TG_PORT=0`); this will work with `meta dev` with embedded typegate if you set the `--gate` option with port `0`. <!-- 2. Explain WHY the change cannot be made simpler --> <!-- 3. Explain HOW users should update their code --> #### Migration notes ... - [x] The change comes with new or modified tests - [x] Hard-to-understand functions have explanatory comments - [ ] End-user documentation is updated to reflect the change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve MET-94
runtimefield fromTypeNodeAlso:
Migration notes
N/A
Checklist