Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gate): empty object as custom scalar #876

Merged
merged 2 commits into from
Oct 17, 2024
Merged

feat(gate): empty object as custom scalar #876

merged 2 commits into from
Oct 17, 2024

Conversation

michael-0acf4
Copy link
Contributor

@michael-0acf4 michael-0acf4 commented Oct 15, 2024

  • Allow empty object on the output without any change
  • Just like Int, String, and such, rightfully refer the constant {} as a scalar
  • Any empty object will now be refered as EmptyObject scalar

Migration notes

None

  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 67.44186% with 56 lines in your changes missing coverage. Please review.

Project coverage is 77.01%. Comparing base (bbef981) to head (f0bed37).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/typegate/src/runtimes/typegraph.ts 60.19% 41 Missing ⚠️
src/typegate/src/engine/typecheck/result.ts 69.76% 13 Missing ⚠️
src/typegate/src/typegraph/mod.ts 90.90% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #876      +/-   ##
==========================================
- Coverage   77.09%   77.01%   -0.08%     
==========================================
  Files         149      149              
  Lines       17849    17867      +18     
  Branches     1730     1737       +7     
==========================================
  Hits        13761    13761              
- Misses       4065     4083      +18     
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Natoandro Natoandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
There are a lot of formatting-related changes 🤔

@michael-0acf4
Copy link
Contributor Author

michael-0acf4 commented Oct 17, 2024

Great! There are a lot of formatting-related changes 🤔

yes, sorry for that. I believe it is because these files were never touched after we dropped the deno formatter.

@michael-0acf4 michael-0acf4 merged commit 1203968 into main Oct 17, 2024
13 of 15 checks passed
@michael-0acf4 michael-0acf4 deleted the empty-object branch October 17, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants