-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for async dynamic attributes #443
Comments
@radekmie can you shortly explain, why it's not working? Is it the way how the updater is wrapped in the autorun or because the flatten and expand functions are all sync or even something else? I was playing around a bit and Promises resolve without breaking tests, but the attributes were in the end not set. I'd like to understand why that is |
No, there are no "limitations". It's just a different part of code (not shared with singular attributes) and it'd require separate implementation. I have it partly working locally and plan to finish it by the end of the next week. |
@radekmie you can also create a draft PR and I can chime in if that makes sense |
Implemented async dynamic attributes (closes #443).
As I wrote in #428, async dynamic attributes (i.e.,
<img {{getAttributesAsync}}>
) is not supported yet. I believe it should be enough to cover it with something likewaitForAllAttributesAndContinue
for standard attributes, but also lifted for arrays (i.e., support arrays of objects withPromise
s).Currently, it can be worked around by using an additional
#let
.The text was updated successfully, but these errors were encountered: