Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for async dynamic attributes #443

Closed
radekmie opened this issue Dec 18, 2023 · 3 comments · Fixed by #460
Closed

Support for async dynamic attributes #443

radekmie opened this issue Dec 18, 2023 · 3 comments · Fixed by #460
Assignees
Milestone

Comments

@radekmie
Copy link
Collaborator

radekmie commented Dec 18, 2023

As I wrote in #428, async dynamic attributes (i.e., <img {{getAttributesAsync}}>) is not supported yet. I believe it should be enough to cover it with something like waitForAllAttributesAndContinue for standard attributes, but also lifted for arrays (i.e., support arrays of objects with Promises).

Currently, it can be worked around by using an additional #let.

@jankapunkt
Copy link
Collaborator

jankapunkt commented Jan 9, 2024

@radekmie can you shortly explain, why it's not working? Is it the way how the updater is wrapped in the autorun or because the flatten and expand functions are all sync or even something else?

I was playing around a bit and Promises resolve without breaking tests, but the attributes were in the end not set. I'd like to understand why that is

@radekmie
Copy link
Collaborator Author

radekmie commented Jan 9, 2024

No, there are no "limitations". It's just a different part of code (not shared with singular attributes) and it'd require separate implementation. I have it partly working locally and plan to finish it by the end of the next week.

@jankapunkt
Copy link
Collaborator

@radekmie you can also create a draft PR and I can chime in if that makes sense

@radekmie radekmie linked a pull request Jan 13, 2024 that will close this issue
Grubba27 added a commit that referenced this issue Feb 29, 2024
Implemented async dynamic attributes (closes #443).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Being worked on
Development

Successfully merging a pull request may close this issue.

2 participants