Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for docsearch appId for custom search deployments. #54

Merged
merged 2 commits into from
Mar 16, 2018

Conversation

abernix
Copy link
Contributor

@abernix abernix commented Mar 16, 2018

From my verbose commit message:

e4ed72b (Jesse Rosenberger, 34 minutes ago)

   This only seems to be important to me for the moment because of my need to
   test search improvements.  Typically, Algolia docsearch runs their own free
   deployment for open-source projects.  This is done through a public
   configuration repository available at
   https://github.com/algolia/docsearch-configs.

   However, in order to test these configurations, it's necessary to run your
   own deployment through their paid service (or a free trial!).  Their public
   service defaults to their own app, but when using the paid service, it's
   necessary to specify the `appId`, which this new code allows.

And a related enhancement:

58fac8d (Jesse Rosenberger, 35 minutes ago)
   Only inject docsearch JavaScript when docsearch is enabled.

   While this won't be necessary for much longer since we'll enable it
   everywhere (hopefully), there's no sense in loading extra unused JavaScript
   on repositories that may choose to not have search, or just don't have it
   configured yet.

While this won't be necessary for much longer since we'll enable it
everywhere (hopefully), there's no sense in loading extra unused JavaScript
on repositories that may choose to not have search, or just don't have it
configured yet.
This only seems to be important to me for the moment because of my need to
test search improvements.  Typically, Algolia docsearch runs their own free
deployment for open-source projects.  This is done through a public
configuration repository available at
https://github.com/algolia/docsearch-configs.

However, in order to test these configurations, it's necessary to run your
own deployment through their paid service (or a free trial!).  Their public
service defaults to their own app, but when using the paid service, it's
necessary to specify the `appId`, which this new code allows.
@abernix abernix merged commit b56b21d into master Mar 16, 2018
@abernix abernix deleted the abernix/docsearch-changes branch March 16, 2018 11:52
abernix added a commit to apollographql/apollo-client that referenced this pull request Mar 20, 2018
As this version supports new search parameters, like `appId`.

Ref: meteor/meteor-theme-hexo#54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant