Separate each script tag into its own context to limit error scope.
#67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, a result of the problem reported in #65 is that all other JavaScript, including search, was prevented from working because they all lived in a shared `<script>` tag. This change puts each concern in its own `<script>` tag to isolate the damage by those script tags. Of course, each of the script providers would have had this in their own code-snippets they offer for copy-pasting, but I guess we decided to put them all in a single `<script>` tag at one point. 😢 Ref: https://github.com/meteor/meteor-theme-hexo/commits/544f1f4084 Ref: #65
abernix
force-pushed
the
abernix/separate-script-tags-to-own-contexts
branch
from
7df2e16
to
ac94ffe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, a result of the problem reported in #65 is that all other
JavaScript, including search, was prevented from working because they all
lived in a shared
<script>tag. This change puts each concern in its own<script>tag to isolate the damage by those script tags.Of course, each of the script providers would have had this in their own
code-snippets they offer for copy-pasting, but I guess we decided to put
them all in a single
<script>tag at one point. 😢Ref: #65
Ref: 544f1f408