Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign Theme for Apollo Docs #71

Merged
merged 30 commits into from
May 31, 2018
Merged

Redesign Theme for Apollo Docs #71

merged 30 commits into from
May 31, 2018

Conversation

unicodeveloper
Copy link

No description provided.

@stubailo
Copy link
Contributor

Good change :shipit:

@unicodeveloper
Copy link
Author

Lmao @stubailo

@unicodeveloper unicodeveloper changed the title Edit header to test deployment Redesign Apollo Docs May 17, 2018
@unicodeveloper unicodeveloper changed the title Redesign Apollo Docs Redesign Theme for Apollo Docs May 17, 2018
@unicodeveloper
Copy link
Author

unicodeveloper commented May 17, 2018 •
edited
Loading

First draft. Check it out @abernix @stubailo @evans

@stubailo
Copy link
Contributor

image

A few comments:

  1. The highlight color in the sidebar should probably extend all the way across, and not have the arrow anymore
  2. The title in the top left looks oddly tall - could be a firefox issue though

Looks a lot better already, just a few more tweaks and I'd say it's a big win!

@abernix
Copy link
Contributor

abernix commented May 22, 2018

I'm guessing the oddly-tall factor (not just a Firefox thing) is in order to match up the position of the text up with the text on the navigation for apollographql.com itself? Agree about the other tweaks @stubailo suggested though!

@unicodeveloper
Copy link
Author

Will work on 1 today @stubailo. For 2. I don't think we need to change anything about that. I agree with @abernix.

@abernix
Copy link
Contributor

abernix commented May 29, 2018

fyi: For testing purposes, I published this as [email protected] on the beta npm dist-tag.

@abernix
Copy link
Contributor

abernix commented May 30, 2018

Heads up, it appears the search results are misbehaving, as seen on this Netlify preview: image.

@unicodeveloper
Copy link
Author

unicodeveloper commented May 30, 2018 •
edited
Loading

That's interesting. I need to change the style for algolia-docsearch-suggestion

abernix
abernix previously requested changes May 31, 2018
View reviewed changes
source/style/_global/docsearch.less
@@ -1,5 +1,5 @@
@color-highlight-header-background: @color-mediumlight;
@color-highlight-text: @color-primary;
@color-highlight-text: @color-text-highlight;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible that these changes are going to break the Meteor search? (They're in _global.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind. Looks okay!

image

source/style/_theme/colors.less Outdated
@@ -168,7 +166,8 @@
padding: 0;
margin-top: 0;
.menu-content {
background-color: transparent;
//background-color: transparent;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strong preference to remove commented code unless there's a compelling reason to keep it around.

source/style/_theme/colors.less Outdated
}

select {
color: @color-lightest;
}

.topcap {
background-color: darken(#2c2f39, 5%);
background: #353c58;
//background-color: darken(#2c2f39, 5%);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might as well remove the commented code here.

source/style/_theme/sidebar.less Outdated
@@ -48,7 +48,7 @@
padding-left: 0;
margin: 0;

.std-xpadding;
//.std-xpadding;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove it!

@abernix
Copy link
Contributor

abernix commented May 31, 2018

@unicodeveloper Can we make this not pink for Meteor? image

@abernix abernix merged commit 69edbc4 into master May 31, 2018
@abernix abernix deleted the redesign branch May 31, 2018 18:12
@abernix
Copy link
Contributor

abernix commented May 31, 2018

This is an incredible update to the Apollo theme. Thanks so much for implementing this, @unicodeveloper. And thank you for the beautiful design, @itsjessmarina!

abernix referenced this pull request in apollographql/apollo-ios May 31, 2018
@renovate @abernix
chore(deps): update dependency meteor-theme-hexo to v1.0.13 (#285)
75b83a9 
This Pull Request updates dependency [meteor-theme-hexo](https://github.com/meteor/meteor-theme-hexo) from `v1.0.10` to `v1.0.13`



<details>
<summary>Release Notes</summary>

### [`v1.0.13`](https://github.com/meteor/meteor-theme-hexo/blob/master/CHANGELOG.md#v1013)
[Compare Source](meteor/meteor-theme-hexo@v1.0.12...v1.0.13)
* Align headings with tiered structure content.
  [PR #&#8203;78](`https://github.com/meteor/meteor-theme-hexo/pull/78`)

---

### [`v1.0.12`](https://github.com/meteor/meteor-theme-hexo/blob/master/CHANGELOG.md#v1012)
[Compare Source](meteor/meteor-theme-hexo@v1.0.11...v1.0.12)
* Fix the tiered structure of the sidebar items to maintain content nesting!
  [PR #&#8203;77](`https://github.com/meteor/meteor-theme-hexo/pull/77`)

---

### [`v1.0.11`](https://github.com/meteor/meteor-theme-hexo/blob/master/CHANGELOG.md#v1011)
[Compare Source](meteor/meteor-theme-hexo@2b6e168...v1.0.11)
* Update theme with new look for Apollo.  The Meteor theme is mostly untouched
  but there have been some small changes in it as well.
  [PR #&#8203;71](`https://github.com/meteor/meteor-theme-hexo/pull/71`)

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).
abernix referenced this pull request in apollographql/apollo-kotlin May 31, 2018
@renovate @abernix
chore(deps): update dependency meteor-theme-hexo to v1.0.13 (#933)
5357eb8 
This Pull Request updates dependency [meteor-theme-hexo](https://github.com/meteor/meteor-theme-hexo) from `v1.0.10` to `v1.0.13`



<details>
<summary>Release Notes</summary>

### [`v1.0.13`](https://github.com/meteor/meteor-theme-hexo/blob/master/CHANGELOG.md#v1013)
[Compare Source](meteor/meteor-theme-hexo@v1.0.12...v1.0.13)
* Align headings with tiered structure content.
  [PR #&#8203;78](`https://github.com/meteor/meteor-theme-hexo/pull/78`)

---

### [`v1.0.12`](https://github.com/meteor/meteor-theme-hexo/blob/master/CHANGELOG.md#v1012)
[Compare Source](meteor/meteor-theme-hexo@v1.0.11...v1.0.12)
* Fix the tiered structure of the sidebar items to maintain content nesting!
  [PR #&#8203;77](`https://github.com/meteor/meteor-theme-hexo/pull/77`)

---

### [`v1.0.11`](https://github.com/meteor/meteor-theme-hexo/blob/master/CHANGELOG.md#v1011)
[Compare Source](meteor/meteor-theme-hexo@2b6e168...v1.0.11)
* Update theme with new look for Apollo.  The Meteor theme is mostly untouched
  but there have been some small changes in it as well.
  [PR #&#8203;71](`https://github.com/meteor/meteor-theme-hexo/pull/71`)

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).
@abernix abernix mentioned this pull request Jun 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abernix abernix abernix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@unicodeveloper @stubailo @abernix