-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade rose edit to Python 3 #2808
Open
astroDimitrios
wants to merge
186
commits into
metomi:master
Choose a base branch
from
astroDimitrios:feature/rose-config-py3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
186 commits
Select commit
Hold shift + click to select a range
07b3627
Remove dead_ends for config-edit and edit. Add in entry point for ros…
astroDimitrios d5f9cc1
Add config_editor dir created by running 2to3 and the pygobject conve…
astroDimitrios ff78b16
Convert imports and usage from rose. to metomi.rose.
astroDimitrios b243093
Fix double word metomi in main.py and __init__.py imports
astroDimitrios cb129de
Convert missed files to gtk3 and add gtk rose dir.
astroDimitrios d790df9
Add gtk dir.
astroDimitrios 5f56ae4
Add Gdk import.
astroDimitrios 5b1242f
Change import rose to import metomi.rose
astroDimitrios 24ad9eb
Add GdkPixbuf imports.
astroDimitrios d69e2a2
Remove the cylc engine imports.
astroDimitrios 2400426
Fix rose import and remove gtk version check.
astroDimitrios 07bf1f3
Add image files for the gui.
astroDimitrios 67ee157
Update resource locations in main.py for rose.
astroDimitrios f41fd83
Update usage of Pango parse_markup().
astroDimitrios 63b97da
Update vbox code in gtk/dialog.py.
astroDimitrios d676af6
Change window top level function call.
astroDimitrios e157798
Update dialog.py scrollbar code.
astroDimitrios 6f2c906
Update pango parse_markup() in gtk/util.py.
astroDimitrios 1ae1551
Update icons and use of Pixbuf.
astroDimitrios dc12b2a
Update splash.py communicate function.
astroDimitrios 9cb36f7
Add padding to pack_start for hor Box in gtk/util.py.
astroDimitrios 090ccff
Correct Gtk import.
astroDimitrios c7334c0
Menu button init fix in gtk/util.py.
astroDimitrios 81b40bd
Image menu item fix in gtk/util.py.
astroDimitrios 947ee80
Remove pos keyword var in call to self.uimanager.insert_action_group
astroDimitrios 7b76445
Alter connect_group to connect.
astroDimitrios 7e558c2
Remove extra TreeViewColumn.pack_start() call args.
astroDimitrios 2e3b3ee
Convert xpm to png as xpm loading is now off by default in Gdk Pixbuf.
astroDimitrios 023888a
Fix .sort() with key from custom cmp function.
astroDimitrios d534772
Add padding to more pack_start() calls.
astroDimitrios 63a9950
Remove xpm reference and replace with png.
astroDimitrios b663930
Remove styling temporarily.
astroDimitrios a1fc94e
Fix window default icon list.
astroDimitrios 0b7ee7e
Fix more pack_start() padding calls.
astroDimitrios c2ab3d4
Fix subprocess communicate in splash.py.
astroDimitrios dda60f4
Open splash as a separate rose command / process.
astroDimitrios b251cc3
Set splash screen gravity.
astroDimitrios 6ca2fce
Fix Image new_from_file_call.
astroDimitrios e944c11
Remove cmp and positional arg from sort.
astroDimitrios 3962815
Remove sort positional arg in menu.py.
astroDimitrios 49bd8f3
Remove cmp from util.py.
astroDimitrios 6aa4697
Add data empty input arg for the get_should_show visibility function.
astroDimitrios a6952c9
Fix data_helper sort with positional arg.
astroDimitrios 8a9e94a
Fix _get_should_show call.
astroDimitrios b1ae274
Remove spurious print and fix sort().
astroDimitrios 20e6b70
Update splash screen communication.
astroDimitrios 6d97c26
Gtk.VBox changed to GtkBox(...VERTICAL) and padding option added to a…
J-J-Abram 6794e89
Gtk.HBox changed to GtkBox(...HORIZONTAL) and padding option added to…
J-J-Abram b50536f
Replacing all remaining instances of VBox and HBox throughout directo…
J-J-Abram ddf535b
Merge pull request #3 from astroDimitrios/feature/VBox_HBox-removal
astroDimitrios e4b7774
Update splash screen code so that it closes properly.
astroDimitrios 277eb0a
Merge branch 'feature/rose-config-py3' of github.com:astroDimitrios/r…
astroDimitrios 459cc02
replacing instances of cmp() and updating .sort() to .sort(key=...), …
J-J-Abram 7342cf8
Merge branch 'feature/rose-config-py3' into feature/cmp_replace
astroDimitrios e5190db
Merge pull request #4 from astroDimitrios/feature/cmp_replace
astroDimitrios 6c3454a
Add padding to pack_start calls.
astroDimitrios 5f8f678
Fix colour of vidget.
astroDimitrios 81e0cd9
Remove colour info and set via css.
astroDimitrios 8878674
Add padding to pack_start and pack_end
astroDimitrios 9ce9c7c
Remove style / colour code
astroDimitrios 8700c23
Fix get_size etc code for widgets
astroDimitrios 9998a4e
Add padding to pack_start
astroDimitrios 5953037
TreeView pack_start args fix
astroDimitrios 60cc0b5
Fix more pack_start calls
astroDimitrios 5fa01e2
Temp fix for select_row
astroDimitrios 76a49dc
Replace size_request call
astroDimitrios f84aab1
Add in 6th arg BaseSummaryDataPanel function
astroDimitrios 612dced
Fix more pack_start
astroDimitrios 5e285d6
Fix pack start
astroDimitrios 2778235
Import python_list correctly and fix padding in pack_start
astroDimitrios 1a19718
Remove more colour info
astroDimitrios 900ea49
Pango underline fix
astroDimitrios bae2cd7
Remove Gtk.Arrow
astroDimitrios 6c849e1
Fix use of text buffer in TextView
astroDimitrios 8b6f38e
Fix style
astroDimitrios 69057ea
Fix Pango attribute code in the keywidget
astroDimitrios b161bfc
Fix pack_start
astroDimitrios 6c32af5
Change rose. to metomi.rose.
astroDimitrios fb8e5dd
Formatting fix
astroDimitrios ebc9b82
Change rose. to metomi.rose.
astroDimitrios ec446b8
Fix 2 button press
astroDimitrios 3786208
Fix text buffer call
astroDimitrios 94a5670
Remove size_request()
astroDimitrios ea67837
Fix flags including SENSITIVE
astroDimitrios fd56615
Fix scrollbar adjustment
astroDimitrios 72c8b36
Fix sort in util.py
astroDimitrios b00ad0d
Fix popup call in MenuWidget
astroDimitrios a1705c2
Fix insert_action_group call in MenuWidget
astroDimitrios 079d0e4
Fix console pack_start calls
astroDimitrios b01ee3e
Fix sort
astroDimitrios e74e03c
Fix get child focus attribute
astroDimitrios c01e447
Fix sort
astroDimitrios bd9fb56
Fix log level for plain text message
astroDimitrios 71f24cc
#11 Feature/button removal
J-J-Abram c258858
Fix import
astroDimitrios b107e6a
Fix get focus child calls
astroDimitrios 9abd3a7
Fix rose import
astroDimitrios b50b4cd
Import submodules
astroDimitrios 4b9b2a4
Fix pack_start calls
astroDimitrios 7866c29
Fix calls to _set_cell_*
astroDimitrios ae8c813
Fix pack_start
astroDimitrios ba2d88a
Fix maths in widget
astroDimitrios 5c82d7b
Merge branch 'feature/rose-config-py3' of github.com:astroDimitrios/r…
astroDimitrios 9f32ce0
Fix keywidget VBox
astroDimitrios 7a778aa
Remove ImageMenuItem
astroDimitrios e0aa5aa
Remove ImageMenuItem
astroDimitrios a0fa0fa
Fix credit/about dialog
astroDimitrios 3d32fe9
Fix insert_action_group() calls
astroDimitrios 4fac5cf
Fix launch menu popup in page.py
astroDimitrios 649f177
Fix insert_action_group() call
astroDimitrios 2019895
Fix .sort call
astroDimitrios e2c25cd
Set styling for the page tabs
astroDimitrios 8b6f2a7
Fix Pango underlining
astroDimitrios 8746e9b
Fix pack_start call
astroDimitrios bb711cb
Fix get_focus_child call
astroDimitrios a3eb8e6
#16 Fix orientation of boxes that used to be VBox()
J-J-Abram 192111c
Fix sort() call
astroDimitrios b99b3e3
Fix get_focus_child() call
astroDimitrios 1c80c07
Fix .popup call
astroDimitrios a645b48
Fix issue with duplicate ns sorting app 10
astroDimitrios fd87f1e
Fix accelerator connection
astroDimitrios dc62ff0
Fix get_upper etc calls
astroDimitrios 6304b44
Fix get_upper etc calls
astroDimitrios aef9762
Fix pack start call
astroDimitrios b231a7d
Fix page tab names
astroDimitrios 04cba40
Fix dict key access
astroDimitrios e53ee80
Use size var for size of Icon not hard coded value
astroDimitrios 83704f2
Fix pack_start call
astroDimitrios dabf4a7
Fix sort call
astroDimitrios 166c826
Fix inspect module calls
astroDimitrios fd94c2f
Fix pack start calls
astroDimitrios 0e9dd14
Fix use of size_request()
astroDimitrios 93c3dd2
Remove top and bottom border from main page window
astroDimitrios c9f1774
Replace Dialog Question stock id
astroDimitrios f7bd1d0
Fix macro button and submenu
astroDimitrios 7607701
Fix to deal with comparison of NoneTypes and strings - None for secti…
astroDimitrios 9a7328b
Fix for internal link focusing
astroDimitrios da29ebe
Fix sort argument
astroDimitrios f9bc0b5
Fix dialog icon in top menu bar
astroDimitrios 4c20af7
Fix rose-gtk icons for CustomButtons
astroDimitrios b1a1dfa
Fix incorrect Image code
astroDimitrios 0845409
Fix sort() calls
astroDimitrios 7205e68
Remove cylc code
astroDimitrios 727abde
Remove min pygtk version code
astroDimitrios 8c9cb02
#20 All references to popup() changed to gtk_menu_popup_at_widget
J-J-Abram e0363ec
Fix popup at widget calls
astroDimitrios f4bd9d3
Fix gravity arguments for popup widget calls
astroDimitrios 20c47e1
Fix pack start calls
astroDimitrios 8b1fec0
Fix popup at widget call by importing Gdk for the gravity arguments
astroDimitrios 0a04977
Fix invisible package menu text on the UM stash summary data panel
astroDimitrios 1080e35
Add extra arg to visibility related functions in stash.py
astroDimitrios 5c7a1d1
Fix pack start calls
astroDimitrios bf35334
Fix invisible text in stash_add / add stashdiagnosticspanel
astroDimitrios 7ac2218
Fix incorrect call to 2 button press event
astroDimitrios 03e943d
Fix popup at widget gravity arguments
astroDimitrios ad0b127
Remove accidental comment in summary_data.py
astroDimitrios 25ef8b4
Remove entry box coral colour for Oliver
astroDimitrios 75771a3
Update importlib code when importing custom widgets in resource.py
astroDimitrios 8df60a4
Change search box from an Entry to a SearchEntry box and add default …
astroDimitrios f2bfd21
Add pygobject as a rose-edit dependency for install (#35)
astroDimitrios aa545d8
Removing all references to pygtk (#41)
J-J-Abram f08916b
Feature/33 separator (#42)
J-J-Abram ab74d43
Move GUI image resources into package (#43)
jfrost-mo 8350739
turorial username file updated to gtk3 and python3 (#45)
J-J-Abram a24f04a
Re-enable plotting of Metadata graphs
astroDimitrios d1462c9
Merge branch 'feature/rose-config-py3' of github.com:astroDimitrios/r…
astroDimitrios aee6d9c
Update css comment for making widgets distinct from each other with a…
astroDimitrios 4043694
Update setter functions to fix python list formatting (#46)
J-J-Abram 7363a43
Fix array widget bug which forced widgets to scroll off screen when a…
astroDimitrios cc41819
Merge branch 'feature/rose-config-py3' of github.com:astroDimitrios/r…
astroDimitrios dd96cd9
Merge branch 'metomi:master' into feature/rose-config-py3
astroDimitrios ea2db96
Black format the gui code
astroDimitrios 1e4a17d
Merge branch 'feature/rose-config-py3' of github.com:astroDimitrios/r…
astroDimitrios fbfc775
Fix line length issues
astroDimitrios e60987e
Change ambiguous variable name l
astroDimitrios 627f0aa
Add noqa comment on Gtk import to set INTERACTIVE_ENABLED
astroDimitrios 38c158f
Remove unused imports
astroDimitrios 03f657c
Fix undefined name radio_button issue flake8 F821
astroDimitrios 59740e3
Removing instances of 'SuiteRunner' for flake8 undefined name F821 ch…
J-J-Abram 1b887d7
Addressing half of the flake8 issues in config_editor (#49)
J-J-Abram 955d492
Fix flake8 issues
astroDimitrios 0f32917
Merge branch 'feature/rose-config-py3' of github.com:astroDimitrios/r…
astroDimitrios 7292832
Add noqa comment for line length errors when importing from metomi.ro…
astroDimitrios 5f72b76
Remove reference to no GUI in the README
astroDimitrios 18dd61f
Remove no Rose 2 GUI warning in the Sphinx docs
astroDimitrios 867c159
Fix flake8 errors in resource.py and reporter.py
astroDimitrios File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤣