Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: correct options for possible location of rose.conf #2810

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

jmarshrossney
Copy link
Contributor

Changed 2 lines in the docs for configuring rose:

/etc/.metomi/rose.conf --> /etc/rose.conf
$ROSE_SITE_CONF_PATH/.metomi/rose.conf --> $ROSE_SITE_CONF_PATH/rose.conf

The docstring is correct.

Cheers!

Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look at the code, this all seems correct to me.

Thanks!

@oliver-sanders
Copy link
Member

oliver-sanders commented Sep 26, 2024

Thanks for sorting this out @jmarshrossney.

For legal reasons, when people make their first contribution to Rose (no matter how big or small), they need to add their name to the CONTRIBUTING.md file before we are allowed to accept their commit. This indicates that you have accepted the contributor licence agreement (CLA).

Could you please add marshrossney to the CONTRIBUTING.md file. Note, this must match the format returned by git shortlog -se.

If you would like to change the appearance of your name, then add an entry to the .mailmap file like so:

diff --git a/.mailmap b/.mailmap
index f1e6d5759..9b4a4794a 100644
--- a/.mailmap
+++ b/.mailmap
@@ -35,3 +35,4 @@ Thomas Coleman       <[email protected]>          Tom Coleman          <
 Tim Pillinger        <[email protected]>     wxtim                <[email protected]>
 Tim Pillinger        <[email protected]>
 Tomasz Trzeciak      <[email protected]>   TomekTrzeciak        <[email protected]>
+First Last           <[email protected]>

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 541e8889e..1f819233e 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -53,6 +53,7 @@ below:
  - Ronnie Dutta (Met Office, UK)
  - Roddy Sharp (Met Office UK)
  - Mark Dawson (Met Office UK)
+ - First Last
 <!-- end-shortlog -->
 
 (All contributors are identifiable with email addresses in the version control

@jmarshrossney
Copy link
Contributor Author

Fair dos

.mailmap Outdated Show resolved Hide resolved
@jmarshrossney
Copy link
Contributor Author

Apologies for the github username/email complications! That's my mistake.

@oliver-sanders
Copy link
Member

No probs, it's just a hoop we have to jump through.

@oliver-sanders oliver-sanders merged commit 1a673c8 into metomi:master Sep 30, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants