Fix traceback when git is not installed #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
3 tasks
wxtim
approved these changes
Oct 23, 2024
|
Do you think it needs a 2nd reviewer? |
Borderline, but I think it does on balance. |
| @@ -268,7 +268,7 @@ def run_bg(self, *args, **kwargs): | |||
| except OSError as exc: | |||
| if exc.filename is None and args: | |||
| exc.filename = args[0] | |||
| raise RosePopenError(args, 1, "", str(exc)) | |||
| raise RosePopenError(args, exc.errno, "", str(exc)) from None | |||
There was a problem hiding this comment.
Python's errnos are between 1 and 132, so this should be fine.
oliver-sanders
approved these changes
Oct 24, 2024
|
(poked tests) |
|
Hmm, the Python 3.7 tests seem to be consistently hanging 😢 But not for me locally with a fresh Python 3.7 environment |
It looks like that is also happening on master. https://github.com/metomi/rose/actions/runs/11587156748 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2809 - fixes
rose app-runandrose task-runcrashing if git is not installed