Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix show function FQN in instrumentation exception #897

Merged
merged 2 commits into from
Aug 8, 2023
Merged

fix show function FQN in instrumentation exception #897

merged 2 commits into from
Aug 8, 2023

Conversation

armed
Copy link
Contributor

@armed armed commented Apr 17, 2023

fixes #896

@ikitommi ikitommi merged commit 386eb3f into metosin:master Aug 8, 2023
@ikitommi
Copy link
Member

ikitommi commented Aug 8, 2023

Thanks!

@NoahTheDuke
Copy link
Contributor

I know this was just merged, but should the re-throw include the caught ex as the cause in ex-info? (throw (ex-info (str ...) (ex-data ex) ex))

@ikitommi
Copy link
Member

Good point. I'll postprocess this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

malli.dev/start! exception does not contain source
3 participants
@armed @ikitommi @NoahTheDuke