Add wrapper types to move from raw integers to types. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Values that would previously return reference time-scaled times as u64 will now return a new type: Instant. This is not the same Instant from std::time, but provides many of the same methods, and will at least provide methods to calculate deltas, etc, that spit out std::time::Duration. As well, the type has a method for extracting the raw u64 value for manual manipulation. This is a move towards being able to better differentiate between the timebase of the source and the reference clocks, as well as provide more natural interoperability with the std::time API. Also cleaned up some dependencies, including avoiding an implicit dependency on metrics-core, instead moving it to be a conditional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Values that would previously return reference time-scaled times as u64 will now return a new type: Instant. This is not the same
Instantfromstd::time, but provides many of the same methods, and will at least provide methods to calculate deltas, etc, that spit outstd::time::Duration. As well, the type has a method for extracting the raw u64 value for manual manipulation.This is a move towards being able to better differentiate between the timebase of the source and the reference clocks, as well as provide more natural interoperability with the
std::timeAPI.Also cleaned up some dependencies, including avoiding an implicit dependency on
metrics-core, instead moving it to be a conditional.