MA0104 only considers public types by default

meziantou · Nov 13, 2023 · c336ad4 · c336ad4
1 parent 1276cbb
commit c336ad4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/docs/Rules/MA0104.md b/docs/Rules/MA0104.md
@@ -6,9 +6,15 @@ public class String // MA0104
 }
 ````
 
-You can configure the types / namespaces to consider in the `editorconfig` file
+You can configure the types / namespaces to consider in the `.editorconfig` file
 
 ````
 MA0104.namespaces_regex = ^System($|\.)
 MA0104.use_preview_types = true # use types from preview versions of .NET
 ````
+
+By default the rule only applies to public types. Add the following line to the `.editorconfig` file to consider all types:
+
+````
+MA0104.only_consider_public_symbols = false
+````
diff --git a/src/Meziantou.Analyzer/Rules/DotNotUseNameFromBCLAnalyzer.cs b/src/Meziantou.Analyzer/Rules/DotNotUseNameFromBCLAnalyzer.cs
@@ -45,6 +45,12 @@ private static void AnalyzeSymbol(SymbolAnalysisContext context)
         if (symbol.ContainingType != null)
             return; // Do not consider nested types
 
+        if (!symbol.IsVisibleOutsideOfAssembly())
+        {
+            if (context.Options.GetConfigurationValue(symbol, RuleIdentifiers.DotNotUseNameFromBCL + ".only_consider_public_symbols", defaultValue: true))
+                return;
+        }
+
         var usePreviewTypes = context.Options.GetConfigurationValue(symbol, RuleIdentifiers.DotNotUseNameFromBCL + ".use_preview_types", defaultValue: false);
         var types = usePreviewTypes ? s_typesPreview : s_types;
         if (types!.TryGetValue(symbol.MetadataName, out var namespaces))