Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

Implement SK_API_VERSION 10 for OpenSSH 9.1 #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tg90nor
Copy link

@tg90nor tg90nor commented Oct 13, 2022

I was unsure of whether to call it version 10 or version a, but went with 10. I will happily change it if you prefer a.

@socram8888
Copy link

Looking at the author's GitHub timeline, looks like he's no longer maintaining his projects. Fork time, maybe?

@socram8888
Copy link

I've created a fork that also fixes compilation under MinGW 11 (Debian Bookworm): https://github.com/socram8888/windows-fido-bridge

@mdeweerd
Copy link

Thanks for the update

It would be helpfull to set the default version tot he maximum - the readme is not very specific about how to pass the option to cmake so it could help save some time ;-)
https://github.com/socram8888/windows-fido-bridge/blob/master/CMakeLists.txt#L30

@socram8888
Copy link

I've barely used CMake, but would it be maybe possible to even detect the locally installed OpenSSH version and adjust it accordingly, if left unspecified?

@mdeweerd
Copy link

Seems possible:
https://stackoverflow.com/a/34140313/6378634 .

One could try to set the variable when it is unset/empty.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants