-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(WIP) Implement application decoupling #959
Changes from all commits
c2e03ed
0129dac
4b2ca0b
8ad5161
595bb48
83de583
78d6019
3d8ffb9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
{ | ||
"name": "angular2-seed", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need a new name here? |
||
"version": "0.0.0", | ||
"description": "Modular seed project for Angular 2 apps with fast, statically typed build", | ||
"repository": { | ||
"url": "https://github.com/mgechev/angular2-seed" | ||
}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need the whole |
||
"author": "Minko Gechev <mgechev>", | ||
"license": "MIT", | ||
"dependencies": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not quite sure which dependencies we need to list here, do we also need There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks fine to me. |
||
"@angular/common": "2.0.0-rc.1", | ||
"@angular/compiler": "2.0.0-rc.1", | ||
"@angular/core": "2.0.0-rc.1", | ||
"@angular/http": "2.0.0-rc.1", | ||
"@angular/platform-browser": "2.0.0-rc.1", | ||
"@angular/platform-browser-dynamic": "2.0.0-rc.1", | ||
"@angular/router": "2.0.0-rc.1", | ||
"es6-module-loader": "^0.17.8", | ||
"core-js": "^2.4.0", | ||
"rxjs": "5.0.0-beta.6", | ||
"systemjs": "0.19.26", | ||
"zone.js": "^0.6.12" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,14 @@ | ||
import * as karma from 'karma'; | ||
import { join } from 'path'; | ||
|
||
import { APP_SRC } from '../../config'; | ||
|
||
/** | ||
* Executes the build process, running all unit tests using `karma`. | ||
*/ | ||
export = (done: any) => { | ||
new (<any>karma).Server({ | ||
configFile: join(process.cwd(), 'karma.conf.js'), | ||
configFile: join(process.cwd(), APP_SRC, 'karma.conf.js'), | ||
singleRun: true | ||
}).start(done); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The angular dependencies here should be dropped. Doesn't seem required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we then also drop the whole
"dependencies": { ... }
section in the rootpackage.json
, since this has moved to thesrc/browser/package.json
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah