Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain vector <0.13 for store's sake. #171

Closed
wants to merge 1 commit into from

Conversation

philderbeast
Copy link
Contributor

I need to constrain vector < 0.13 in order to build store otherwise I get errors like:

src/Data/Store/Internal.hs:824:3: error:
    • No instance for (Store (Data.Vector.Unboxed.Base.Vector b))
        arising from a use of ‘peek’

Looking at vector-0.13 release notes, this is the breaking change:

  • Remove redundant Storable constraints on to/from ForeignPtr conversions: #394

I first encountered this on ucsd-progsys/liquid-fixpoint#609

@mgsloan
Copy link
Owner

mgsloan commented Aug 3, 2022

Thanks for the PR!

Instead of adding this upper bound, I'm fixing this instore-0.7.16 by skipping generation of these instances which aren't very useful.

This actually is not caused by a breaking change in vector - vector#378. TH allows you to reify information about other packages in such a way that internal changes can cause breakage.

@mgsloan mgsloan closed this Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants