Re-implement newer
and newer_group
to avoid deprecated distutils.util
#2141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #2119
setuptools.util
does not currently re-expose methods fromdistutils.util
. And may not want to do so (see discussion in pypa/setuptools#4069 ). This PR explores re-implementingnewer
andnewer_group
methods to avoid depending on deprecateddistutils.util
.There might be a better location to move these methods.
The two usages of
newer_group
insetup.py
also come with a comment suggesting that this method may not be necessary and possibly improved/removed in the future. To me it looks like a build optimization to not regenerate certain files. I would like your thoughts on this @mhammond