Remove obsolete and broken unicode compatibility in pywintypes
#2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
pywintypes-remove-redundant-unicode-alias
branch
from
cf643d2
to
b6c856c
Compare
Fix MSOffice excel test. Bad version check
Avasam
force-pushed
the
pywintypes-remove-redundant-unicode-alias
branch
from
b6c856c
to
b474208
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2085 but on side of the exposed C API
UnicodeTypeis just an alias tostrCloses #697 and closes #756 by simply removing the broken method
Unicode.I couldn't find an immediate pure-python equivalent of
UnicodeFromRaw, and the demoE:\Users\Avasam\Documents\Git\pywin32\win32\Demos\BackupSeek_streamheaders.pylooks like it still works fine. SO I left that one alone.Not sure about
IsTextUnicode.I also had to fix the Excel test to work with versions greater than 9, so I could test it myself.