EnsureDispatch: Check for the class attribute 'CLSID' instead of the instance attribute #2353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to decide if building makepy support is required.
geppi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to decide if building makepy support is required.
The current code is checking for the
CLSIDatttribute of the instance created bywin32com.client.Dispatch().This attribute is never set on the instance and therefore the condition is always
Trueand the code to build the makepy support is always executed.The changed code does instead check for the
CLSIDclass attribute which is set by the code that builds the makepy support and therefore avoids executing this code again if the makepy support already exists.This pull request resolves #2354.