Set timeout-minutes in GitHub actions #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, build tests fail but don't raise an error. They get stuck in limbo and timeout after GitHub's limit of 6 hours. See https://github.com/mhammond/pywin32/actions/runs/11188366703/job/31107020384?pr=2321 for the latest example.
Jobs take up to 8m 30s to run. So I doubled that time and nicely rounded it up to 20 minutes.
A shorter timeout allows much quicker feedback on failing jobs. Especially when there's no error to track the breaking change. Of course it'd be nicer if we figured out why it gets stuck, but this is a nice bandaid patch.
Static checkers jobs don't have that issue, but just applied the timeout indiscriminately. See https://github.com/orgs/community/discussions/10690 for a feature request to be configurable at a workflow level (please take the time to upvote if you'd find this valuable)