Security fixes #1216
Closed
Security fixes #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These CORS headers set here are not needed and ineffective - the specific methods which are allowed are not actually used in the app, so these will have no effect. CORS headers should not be set without an explicit purpose, because it could introduce additional vulnerabilities.
…require authentication for websocket
|
It looks like a PR to add full CORS support was added in the meantime. I would recommend removing that PR as it significantly increases the exploitability of CSRF attacks against Flower. |
|
I've resolved the merge conflict relating to the CORS policy by setting the dangerous and unsafe CORS policy behind the same flag ( |
|
this package is not maintained by any active core developers or we don't have commit access to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1209, #1217 and https://tprynn.github.io/2022/05/26/flower-vulns.html