Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support /last and /set-last-id endpoints #13

Closed
wants to merge 2 commits into from
Closed

Support /last and /set-last-id endpoints #13

wants to merge 2 commits into from

Conversation

jiripudil
Copy link
Contributor

No description provided.

jkuchar
jkuchar approved these changes Apr 3, 2018
View reviewed changes
Copy link

@jkuchar jkuchar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mhujer
Copy link
Owner

mhujer commented Apr 12, 2018

Thanks a lot! Merged manually as 9aa8ddb.

Can you please test that everything is smooth in the master, so I can release it?

btw. I've improved the setLastId() test to actually test something 96dc7af ;-)

@mhujer mhujer closed this Apr 12, 2018
@jiripudil jiripudil deleted the download-last branch April 12, 2018 07:17
@jiripudil
Copy link
Contributor Author

We have already used our fork in production for a week, so I believe everything is smooth and ready for release :)

@mhujer
Copy link
Owner

mhujer commented Apr 13, 2018

Released as 4.1.0, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkuchar jkuchar jkuchar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiripudil @mhujer @jkuchar