Add leniency in trailing slash to better accommodate instances mounted in subdirectories #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d in subdirectories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If 0x0 is mounted in a subdirectory of a domain, e.g.
https://example.com/0x0, e.g. via:the welcome message gives non-working commands:
The issue is that flask is expecting to see a trailing slash in such URLs, but it is explicitly removed inside
index.html. We can confirm that adding a trailing slash solves the issue:There are two solutions: either add the trailing slash for all urls in
index.html, or allow leniency in the presence of a trailing slash by addingstrict_slashes=False:@app.route("/", methods=["GET", "POST"], strict_slashes=False)