Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add simpler modality arg #401

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

michaelfeil
Copy link
Owner

No description provided.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR simplifies the API by changing the parameter name from 'infinity_extra_modality' to 'modality' across multiple files in the infinity_emb library.

  • Updated OpenAPI specification in docs/assets/openapi.json to reflect the new 'modality' parameter
  • Modified fastapi_schemas/pymodels.py to use 'modality' instead of 'infinity_extra_modality' in relevant classes
  • Changed infinity_server.py to use 'modality' in the /embeddings endpoint and its documentation
  • Updated test files to use the new 'modality' parameter in API calls and assertions
  • Incremented the version number to 0.0.60 in the OpenAPI specification

6 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.62%. Comparing base (99339a9) to head (fc9113c).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #401   +/-   ##
=======================================
  Coverage   78.62%   78.62%           
=======================================
  Files          39       39           
  Lines        3008     3008           
=======================================
  Hits         2365     2365           
  Misses        643      643           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelfeil michaelfeil merged commit e139fcf into main Oct 7, 2024
36 checks passed
@michaelfeil michaelfeil deleted the revert-modality-to-simpler-arg branch October 7, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants