Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker update trt onnx #432

Merged
merged 3 commits into from
Oct 19, 2024
Merged

Docker update trt onnx #432

merged 3 commits into from
Oct 19, 2024

Conversation

michaelfeil
Copy link
Owner

No description provided.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request introduces TensorRT and ONNX support to the Infinity project, focusing on Docker-related files and build processes.

  • Added new job 'docker-container-push-onnx-trt' in release.yaml for TensorRT and ONNX container
  • Created Dockerfile.trt_onnx_auto with multi-stage build for TensorRT support
  • Updated Docker.template.yaml with new 'trt' section for TensorRT configurations
  • Improved multi-architecture support and testing in Dockerfiles (amd, cpu, nvidia)
  • Added TensorRT Dockerfile generation command in Makefile

8 file(s) reviewed, 10 comment(s)
Edit PR Review Bot Settings | Greptile

pyproject_sed: RUN sed -i 's|"pypi"|"pytorch_rocm"|' pyproject.toml && sed -i 's|torch = "2.4.1"|torch = "2.4.1"|' pyproject.toml && sed -i 's|torchvision = {version = "\*"|torchvision = {version = "0.19.1"|' pyproject.toml && rm poetry.lock
pyproject_sed: |
RUN sed -i 's|"pypi"|"pytorch_rocm"|' pyproject.toml
RUN sed -i 's|torch = "2.4.1"|torch = "2.4.1"|' pyproject.toml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: This sed command doesn't change anything. Consider removing it or updating the version if needed.

poetry_extras: "all onnxruntime-gpu"
extra_installs_main: |
# Install utils for tensorrt
RUN apt-get install -y --no-install-recommends openmpi-bin libopenmpi-dev git git-lfs python3-pip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider using 'apt-get update' before 'apt-get install' to ensure the package list is up-to-date.

libs/infinity_emb/Dockerfile.cpu_auto Show resolved Hide resolved
libs/infinity_emb/Dockerfile.nvidia_auto Show resolved Hide resolved
libs/infinity_emb/Dockerfile.nvidia_auto Show resolved Hide resolved
libs/infinity_emb/Dockerfile.trt_onnx_auto Show resolved Hide resolved
libs/infinity_emb/Dockerfile.trt_onnx_auto Show resolved Hide resolved
libs/infinity_emb/Dockerfile.trt_onnx_auto Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.22%. Comparing base (6df448f) to head (afb764e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #432   +/-   ##
=======================================
  Coverage   79.22%   79.22%           
=======================================
  Files          41       41           
  Lines        3245     3245           
=======================================
  Hits         2571     2571           
  Misses        674      674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelfeil michaelfeil merged commit 6a9f8cd into main Oct 19, 2024
36 checks passed
@michaelfeil michaelfeil deleted the docker-update-trt-onnx branch October 19, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants