-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker update trt onnx #432
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request introduces TensorRT and ONNX support to the Infinity project, focusing on Docker-related files and build processes.
- Added new job 'docker-container-push-onnx-trt' in release.yaml for TensorRT and ONNX container
- Created Dockerfile.trt_onnx_auto with multi-stage build for TensorRT support
- Updated Docker.template.yaml with new 'trt' section for TensorRT configurations
- Improved multi-architecture support and testing in Dockerfiles (amd, cpu, nvidia)
- Added TensorRT Dockerfile generation command in Makefile
8 file(s) reviewed, 10 comment(s)
Edit PR Review Bot Settings | Greptile
pyproject_sed: RUN sed -i 's|"pypi"|"pytorch_rocm"|' pyproject.toml && sed -i 's|torch = "2.4.1"|torch = "2.4.1"|' pyproject.toml && sed -i 's|torchvision = {version = "\*"|torchvision = {version = "0.19.1"|' pyproject.toml && rm poetry.lock | ||
pyproject_sed: | | ||
RUN sed -i 's|"pypi"|"pytorch_rocm"|' pyproject.toml | ||
RUN sed -i 's|torch = "2.4.1"|torch = "2.4.1"|' pyproject.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: This sed command doesn't change anything. Consider removing it or updating the version if needed.
poetry_extras: "all onnxruntime-gpu" | ||
extra_installs_main: | | ||
# Install utils for tensorrt | ||
RUN apt-get install -y --no-install-recommends openmpi-bin libopenmpi-dev git git-lfs python3-pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider using 'apt-get update' before 'apt-get install' to ensure the package list is up-to-date.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #432 +/- ##
=======================================
Coverage 79.22% 79.22%
=======================================
Files 41 41
Lines 3245 3245
=======================================
Hits 2571 2571
Misses 674 674 ☔ View full report in Codecov by Sentry. |
No description provided.