Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New docker image for rocm / torch cpu #434

Merged
merged 2 commits into from
Oct 22, 2024
Merged

New docker image for rocm / torch cpu #434

merged 2 commits into from
Oct 22, 2024

Conversation

michaelfeil
Copy link
Owner

@michaelfeil michaelfeil commented Oct 21, 2024

This pull request includes significant updates to the Docker configurations and dependency management for various environments, including NVIDIA, CPU, AMD, and TensorRT. The changes aim to streamline the installation process and ensure compatibility with updated dependencies.

Docker Configuration Updates:

  • libs/infinity_emb/Docker.template.yaml: Updated the main_install commands for NVIDIA, CPU, and AMD configurations to use a new script requirements_install_from_poetry.sh for better dependency management. [1] [2]

  • libs/infinity_emb/Dockerfile.amd_auto: Changed Poetry virtual environment settings to create and use the environment within the project directory. Updated Poetry version from 1.7.1 to 1.8.4. [1] [2] [3]

  • libs/infinity_emb/Dockerfile.cpu_auto, libs/infinity_emb/Dockerfile.nvidia_auto, libs/infinity_emb/Dockerfile.trt_onnx_auto: Updated Poetry version to 1.8.4 and modified the installation commands to use the new script for dependency management. [1] [2] [3] [4] [5] [6] [7] [8]

Dependency Management:

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request introduces significant changes to the Docker configuration and dependency management for the Infinity project, focusing on improving the build process across different environments.

  • Added requirements_install_from_poetry.sh to manage Python dependencies more efficiently
  • Updated Poetry version to 1.8.4 across all Dockerfiles for consistency
  • Modified TensorRT installation in Dockerfile.trt_onnx_auto, updating to version 10.0.1
  • Enabled modern installation method in poetry.toml for potential performance improvements
  • Updated GPU-related dependencies in pyproject.toml, including pinning onnxruntime-gpu to 1.19.* and upgrading tensorrt to ^10.2.0

9 file(s) reviewed, 12 comment(s)
Edit PR Review Bot Settings | Greptile

RUN poetry run $PYTHON -m pip install --no-cache-dir "tensorrt==10.0.1" "tensorrt_lean==10.0.1" "tensorrt_dispatch==10.0.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: TensorRT version changed from 10.2.0 to 10.0.1. Ensure compatibility with other components

libs/infinity_emb/Dockerfile.amd_auto Show resolved Hide resolved
libs/infinity_emb/Dockerfile.cpu_auto Show resolved Hide resolved
libs/infinity_emb/Dockerfile.cpu_auto Show resolved Hide resolved
libs/infinity_emb/Dockerfile.nvidia_auto Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.16%. Comparing base (62a07c9) to head (e9bc418).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
- Coverage   79.22%   79.16%   -0.07%     
==========================================
  Files          41       41              
  Lines        3245     3245              
==========================================
- Hits         2571     2569       -2     
- Misses        674      676       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelfeil michaelfeil changed the title New docker New docker image for rocm / torch cpu Oct 21, 2024
@michaelfeil michaelfeil merged commit 0ef460b into main Oct 22, 2024
36 checks passed
@michaelfeil michaelfeil deleted the new-docker branch October 22, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants